[GitHub] spark pull request #15515: [SPARK-17970][SQL] store partition spec in metast...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15515#discussion_r84948916
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
    @@ -581,13 +582,30 @@ private[spark] class HiveExternalCatalog(conf: SparkConf, hadoopConf: Configurat
       // Partitions
       // --------------------------------------------------------------------------
     
    +  // Hive metastore is not case preserving and the partition columns are always lower cased. We need
    +  // to lower case the column names in partition specification before calling partition related Hive
    +  // APIs, to match this behaviour.
    +  private def lowerCasePartitionSpec(spec: TablePartitionSpec): TablePartitionSpec = {
    --- End diff --
    
    cc @ericl @yhuai, I have isolated these hive partition hacks in `HiveExternalCatalog`, so that `HiveExternalCatalog` can provides case preserving partition related interfaces.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org