You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/11/08 19:11:01 UTC
[kudu-CR] [rpc] fixed misprint in RegisterConnection
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5003
Change subject: [rpc] fixed misprint in RegisterConnection
......................................................................
[rpc] fixed misprint in RegisterConnection
Fixed misprint in ReactorThread::RegisterConnection: do not put already
shut down connection into the server connection list.
Change-Id: Ifad34fa64caabebe265aea3c629657046b6818b5
---
M src/kudu/rpc/reactor.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/5003/1
--
To view, visit http://gerrit.cloudera.org:8080/5003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifad34fa64caabebe265aea3c629657046b6818b5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [rpc] fixed misprint in RegisterConnection
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [rpc] fixed misprint in RegisterConnection
......................................................................
Patch Set 1:
that's an interesting find. why does this never get triggered? any way to test it?
--
To view, visit http://gerrit.cloudera.org:8080/5003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifad34fa64caabebe265aea3c629657046b6818b5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [rpc] fixed misprint in RegisterConnection
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: [rpc] fixed misprint in RegisterConnection
......................................................................
[rpc] fixed misprint in RegisterConnection
Fixed misprint in ReactorThread::RegisterConnection: do not put already
shut down connection into the server connection list.
Change-Id: Ifad34fa64caabebe265aea3c629657046b6818b5
Reviewed-on: http://gerrit.cloudera.org:8080/5003
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/rpc/reactor.cc
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifad34fa64caabebe265aea3c629657046b6818b5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [rpc] fixed misprint in RegisterConnection
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [rpc] fixed misprint in RegisterConnection
......................................................................
Patch Set 1: Code-Review+2
nah, that's OK. I missed that it is ref-counted and thus it doesn't cause a crash (and hence snuck by without detection)
--
To view, visit http://gerrit.cloudera.org:8080/5003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifad34fa64caabebe265aea3c629657046b6818b5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [rpc] fixed misprint in RegisterConnection
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [rpc] fixed misprint in RegisterConnection
......................................................................
Patch Set 1:
> that's an interesting find. why does this never get triggered? any
> way to test it?
I found that while browsing the code in the context of review your patch https://gerrit.cloudera.org/#/c/4959/ :)
As I understand, the added DOA connection in the container is removed after some time by the ReactorThread::TimerHandler timer task since the connection is idle and its activity time is not updated (default is 65 seconds, as I see). So, not much impact here -- just making the list of connections longer, so all lookups/iterations take.
As for the way to test it -- it's possible to create a test on that, but it would be a little bit invasive (would require friendship from the ReactorThread class). But if you think it's necessary, I can add one.
--
To view, visit http://gerrit.cloudera.org:8080/5003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifad34fa64caabebe265aea3c629657046b6818b5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No