You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/04/24 02:41:50 UTC

[GitHub] [zookeeper] nishanth-entoor opened a new pull request #1332: ZOOKEEPER-3800: improve the log printing the address when QuorumCnxManager#ListenerHandler's port binds

nishanth-entoor opened a new pull request #1332:
URL: https://github.com/apache/zookeeper/pull/1332


   As per [ZOOKEEPER-3800](https://issues.apache.org/jira/browse/ZOOKEEPER-3800), I updated the log message to print the address.
   
   Please let me know if additional changes are required.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] maoling commented on a change in pull request #1332: ZOOKEEPER-3800: improve the log printing the address when QuorumCnxManager#ListenerHandler's port binds

Posted by GitBox <gi...@apache.org>.
maoling commented on a change in pull request #1332:
URL: https://github.com/apache/zookeeper/pull/1332#discussion_r421543941



##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
##########
@@ -1090,7 +1090,7 @@ private void acceptConnections() {
                             break;
                         }
 
-                        LOG.error("Exception while listening", e);
+                        LOG.error("Exception while listening on port {}", address, e);
 

Review comment:
       -  `LOG.error("Exception while listening to address{}", address, e);` is better?
   - I will re-test this patch tomorrow




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] asfgit closed pull request #1332: ZOOKEEPER-3800: improve the log printing the address when QuorumCnxManager#ListenerHandler's port binds

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1332:
URL: https://github.com/apache/zookeeper/pull/1332


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] maoling commented on pull request #1332: ZOOKEEPER-3800: improve the log printing the address when QuorumCnxManager#ListenerHandler's port binds

Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1332:
URL: https://github.com/apache/zookeeper/pull/1332#issuecomment-1000761782


   If no other concerns, I'll merge it at this weekend(12-26)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] maoling closed pull request #1332: ZOOKEEPER-3800: improve the log printing the address when QuorumCnxManager#ListenerHandler's port binds

Posted by GitBox <gi...@apache.org>.
maoling closed pull request #1332:
URL: https://github.com/apache/zookeeper/pull/1332


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] maoling closed pull request #1332: ZOOKEEPER-3800: improve the log printing the address when QuorumCnxManager#ListenerHandler's port binds

Posted by GitBox <gi...@apache.org>.
maoling closed pull request #1332:
URL: https://github.com/apache/zookeeper/pull/1332


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] nishanth-entoor commented on a change in pull request #1332: ZOOKEEPER-3800: improve the log printing the address when QuorumCnxManager#ListenerHandler's port binds

Posted by GitBox <gi...@apache.org>.
nishanth-entoor commented on a change in pull request #1332:
URL: https://github.com/apache/zookeeper/pull/1332#discussion_r421627698



##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
##########
@@ -1090,7 +1090,7 @@ private void acceptConnections() {
                             break;
                         }
 
-                        LOG.error("Exception while listening", e);
+                        LOG.error("Exception while listening on port {}", address, e);
 

Review comment:
       I made the change to the error message. Please check now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] maoling commented on pull request #1332: ZOOKEEPER-3800: improve the log printing the address when QuorumCnxManager#ListenerHandler's port binds

Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1332:
URL: https://github.com/apache/zookeeper/pull/1332#issuecomment-1001114277


   @nishanth-entoor 
   Thanks for your contribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org