You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/10/14 17:38:12 UTC
[GitHub] [camel] gilvansfilho opened a new pull request, #8554: (chores) camel-rest-swagger: fixing a few code violations from SonarCloud
gilvansfilho opened a new pull request, #8554:
URL: https://github.com/apache/camel/pull/8554
Fixed:
- shadowing member variables
- override equals in subclass that add fields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #8554: (chores) camel-rest-swagger: fixing a few code violations from SonarCloud
Posted by GitBox <gi...@apache.org>.
davsclaus merged PR #8554:
URL: https://github.com/apache/camel/pull/8554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8554: (chores) camel-rest-swagger: fixing a few code violations from SonarCloud
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8554:
URL: https://github.com/apache/camel/pull/8554#issuecomment-1280521276
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 1 | 0 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] gilvansfilho commented on a diff in pull request #8554: (chores) camel-rest-swagger: fixing a few code violations from SonarCloud
Posted by GitBox <gi...@apache.org>.
gilvansfilho commented on code in PR #8554:
URL: https://github.com/apache/camel/pull/8554#discussion_r996335010
##########
components/camel-rest-swagger/src/main/java/org/apache/camel/component/rest/swagger/RestSwaggerEndpoint.java:
##########
@@ -308,14 +308,24 @@ RestSwaggerComponent component() {
return (RestSwaggerComponent) getComponent();
}
+ @Override
Review Comment:
Sonar cares about additional [subclass fields and the needeed of add them in equals and hash code methods](https://rules.sonarsource.com/java/RSPEC-2160). In that case this is not necessary as equality is based on context name and endpoint Uri so additional fields dont need to be considered. However sonar points as issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8554: (chores) camel-rest-swagger: fixing a few code violations from SonarCloud
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8554:
URL: https://github.com/apache/camel/pull/8554#issuecomment-1279287554
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a diff in pull request #8554: (chores) camel-rest-swagger: fixing a few code violations from SonarCloud
Posted by GitBox <gi...@apache.org>.
davsclaus commented on code in PR #8554:
URL: https://github.com/apache/camel/pull/8554#discussion_r996270767
##########
components/camel-rest-swagger/src/main/java/org/apache/camel/component/rest/swagger/RestSwaggerEndpoint.java:
##########
@@ -308,14 +308,24 @@ RestSwaggerComponent component() {
return (RestSwaggerComponent) getComponent();
}
+ @Override
Review Comment:
I wonder why sonarcloud reports a problem that equals/hashCode needs to be overridden when they just call super?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org