You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mistercrunch (via GitHub)" <gi...@apache.org> on 2023/07/19 01:31:10 UTC
[GitHub] [superset] mistercrunch opened a new pull request, #24741: chore: make antd table font size same as data table
mistercrunch opened a new pull request, #24741:
URL: https://github.com/apache/superset/pull/24741
### SUMMARY
"Drill to details" uses normal font-size (14px) where all other data tables in Superset use small font size (12px). This sets our Table component based on AntD to use our `typography.sizes.s` while the table is set to a small size.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
#### after
<img width="980" alt="Screen Shot 2023-07-18 at 6 25 53 PM" src="https://github.com/apache/superset/assets/487433/8c1951fd-d38b-423d-a3b1-d8cc563a4756">
#### before
<img width="943" alt="Screen Shot 2023-07-18 at 6 30 25 PM" src="https://github.com/apache/superset/assets/487433/6fa24c51-6762-460a-bd2f-2c79ec1dc822">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mistercrunch commented on pull request #24741: chore: make antd table font size same as data table
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #24741:
URL: https://github.com/apache/superset/pull/24741#issuecomment-1642807858
@michael-s-molina idk, maybe. For now I'm overriding antd's definition of the class `.ant-table-small` and guessing the controls (like pagination) aren't affected when going from small to large. It felt like aligning their definition of small to ours made sense, and things look better as we have fixed column sizes in many places and things are often on the edge of overflowing. I'd love to have some dynamism in the column width eventually ....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mistercrunch merged pull request #24741: chore: make antd table font size same as data table
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch merged PR #24741:
URL: https://github.com/apache/superset/pull/24741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24741: chore: make antd table font size same as data table
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24741:
URL: https://github.com/apache/superset/pull/24741#issuecomment-1641285769
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24741?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24741](https://app.codecov.io/gh/apache/superset/pull/24741?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2004c3e) into [master](https://app.codecov.io/gh/apache/superset/commit/11bb8c35b0ea4d07833a97f02f601048adfc00a4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (11bb8c3) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 2004c3e differs from pull request most recent head 770cd85. Consider uploading reports for the commit 770cd85 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24741 +/- ##
=======================================
Coverage 68.89% 68.89%
=======================================
Files 1901 1901
Lines 73927 73927
Branches 8183 8183
=======================================
Hits 50932 50932
Misses 20874 20874
Partials 2121 2121
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `55.71% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24741?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/components/Table/VirtualTable.tsx](https://app.codecov.io/gh/apache/superset/pull/24741?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGUvVmlydHVhbFRhYmxlLnRzeA==) | `75.00% <ø> (ø)` | |
| [superset-frontend/src/components/Table/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24741?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGUvaW5kZXgudHN4) | `75.58% <ø> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #24741: chore: make antd table font size same as data table
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #24741:
URL: https://github.com/apache/superset/pull/24741#issuecomment-1642504350
Should the pagination also use a 12px font?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org