You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "SimonChou12138 (via GitHub)" <gi...@apache.org> on 2023/12/22 09:33:24 UTC
[PR] [Feature][Connectors-v2-Paimon] Adaptation Paimon 0.6 Version [seatunnel]
SimonChou12138 opened a new pull request, #6061:
URL: https://github.com/apache/seatunnel/pull/6061
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
### Purpose of this pull request
Implement Feature https://github.com/apache/seatunnel/issues/6058
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released SeaTunnel versions or within the unreleased branches such as dev.
If no, write 'No'.
If you are adding/modifying connector documents, please follow our new specifications: https://github.com/apache/seatunnel/issues/4544.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If you are adding E2E test cases, maybe refer to https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf, here is a good example.
-->
Re-run Paimon e2e Test. Perfect Pass
### Check list
* [x] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Connectors-v2-Paimon] Adaptation Paimon 0.6 Version [seatunnel]
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on PR #6061:
URL: https://github.com/apache/seatunnel/pull/6061#issuecomment-1868309179
cc @TyrantLucifer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Connectors-v2-Paimon] Adaptation Paimon 0.6 Version [seatunnel]
Posted by "EricJoy2048 (via GitHub)" <gi...@apache.org>.
EricJoy2048 commented on code in PR #6061:
URL: https://github.com/apache/seatunnel/pull/6061#discussion_r1434901897
##########
seatunnel-connectors-v2/connector-paimon/pom.xml:
##########
@@ -30,7 +30,7 @@
<name>SeaTunnel : Connectors V2 : Paimon</name>
<properties>
- <paimon.version>0.4.0-incubating</paimon.version>
+ <paimon.version>0.6.0-incubating</paimon.version>
Review Comment:
Compatibility needs to be tested to see if the new connector can still be used on payment 0.4.0-incubating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Connectors-v2-Paimon] Adaptation Paimon 0.6 Version [seatunnel]
Posted by "SimonChou12138 (via GitHub)" <gi...@apache.org>.
SimonChou12138 commented on code in PR #6061:
URL: https://github.com/apache/seatunnel/pull/6061#discussion_r1434907002
##########
seatunnel-connectors-v2/connector-paimon/pom.xml:
##########
@@ -30,7 +30,7 @@
<name>SeaTunnel : Connectors V2 : Paimon</name>
<properties>
- <paimon.version>0.4.0-incubating</paimon.version>
+ <paimon.version>0.6.0-incubating</paimon.version>
Review Comment:
Yes, my production environment is paimon 0.6, and I re-typed the connector package to replace the connector of the production environment for testing, which is compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Connectors-v2-Paimon] Adaptation Paimon 0.6 Version [seatunnel]
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on code in PR #6061:
URL: https://github.com/apache/seatunnel/pull/6061#discussion_r1436393880
##########
seatunnel-connectors-v2/connector-paimon/pom.xml:
##########
@@ -30,7 +30,7 @@
<name>SeaTunnel : Connectors V2 : Paimon</name>
<properties>
- <paimon.version>0.4.0-incubating</paimon.version>
+ <paimon.version>0.6.0-incubating</paimon.version>
Review Comment:
At present, there shouldn't be too many changes to Paimon's API. I think the compatibility issue can be temporarily ignored. Upgrading Paimon to the latest version is okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Connectors-v2-Paimon] Adaptation Paimon 0.6 Version [seatunnel]
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 merged PR #6061:
URL: https://github.com/apache/seatunnel/pull/6061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org