You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/06/20 04:17:19 UTC
[GitHub] [incubator-pegasus] foreverneverer opened a new pull request, #1011: feat(docker): support centos6 build env
foreverneverer opened a new pull request, #1011:
URL: https://github.com/apache/incubator-pegasus/pull/1011
# Ref-issue
https://github.com/apache/incubator-pegasus/issues/903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] foreverneverer merged pull request #1011: feat(docker): support centos6 build env
Posted by GitBox <gi...@apache.org>.
foreverneverer merged PR #1011:
URL: https://github.com/apache/incubator-pegasus/pull/1011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #1011: feat(docker): support centos6 build env
Posted by GitBox <gi...@apache.org>.
foreverneverer commented on code in PR #1011:
URL: https://github.com/apache/incubator-pegasus/pull/1011#discussion_r911710601
##########
docker/pegasus-build-env/centos6/Dockerfile:
##########
@@ -0,0 +1,70 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# use the centos with valid yum repo url
+FROM apachepegasus/centos-vault:6.10
Review Comment:
apachepegasus/centos-vault:6.10 use valid and supported repo url
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] foreverneverer closed pull request #1011: feat(docker): support centos6 build env
Posted by GitBox <gi...@apache.org>.
foreverneverer closed pull request #1011: feat(docker): support centos6 build env
URL: https://github.com/apache/incubator-pegasus/pull/1011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1011: feat(docker): support centos6 build env
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1011:
URL: https://github.com/apache/incubator-pegasus/pull/1011#discussion_r911708000
##########
docker/pegasus-build-env/centos6/Dockerfile:
##########
@@ -0,0 +1,70 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# use the centos with valid yum repo url
+FROM apachepegasus/centos-vault:6.10
Review Comment:
What's the different between this image and `centos:centos6.10`?
##########
docker/pegasus-build-env/centos6/Dockerfile:
##########
@@ -0,0 +1,70 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# use the centos with valid yum repo url
+FROM apachepegasus/centos-vault:6.10
+
+LABEL maintainer=jiashuo
+
+RUN yum -y install \
+devtoolset-7-gcc \
+devtoolset-7-gcc-c++ \
+java-1.8.0-openjdk-devel \
+git \
+gettext \
+curl-devel \
+rh-maven33 \
+python27 \
+python34 \
+automake \
+autoconf \
+make \
+libtool \
+file \
+wget \
+ccache \
+nc \
+zip \
+gdb \
+vim \
+unzip \
+which \
+openssl-devel \
+libaio-devel \
+snappy-devel \
+bzip2-devel \
+zlib \
+zlib-devel \
+libzstd-devel \
+lz4-devel \
+bison \
+flex \
+patch; \
Review Comment:
Can krb5-devel and cyrus-sasl-devel be installed on this platform?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] foreverneverer commented on pull request #1011: feat(docker): support centos6 build env
Posted by GitBox <gi...@apache.org>.
foreverneverer commented on PR #1011:
URL: https://github.com/apache/incubator-pegasus/pull/1011#issuecomment-1170955840
@acelyc111 I have fixed it and now can review it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #1011: feat(docker): support centos6 build env
Posted by GitBox <gi...@apache.org>.
foreverneverer commented on code in PR #1011:
URL: https://github.com/apache/incubator-pegasus/pull/1011#discussion_r911711201
##########
docker/pegasus-build-env/centos6/Dockerfile:
##########
@@ -0,0 +1,70 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# use the centos with valid yum repo url
+FROM apachepegasus/centos-vault:6.10
+
+LABEL maintainer=jiashuo
+
+RUN yum -y install \
+devtoolset-7-gcc \
+devtoolset-7-gcc-c++ \
+java-1.8.0-openjdk-devel \
+git \
+gettext \
+curl-devel \
+rh-maven33 \
+python27 \
+python34 \
+automake \
+autoconf \
+make \
+libtool \
+file \
+wget \
+ccache \
+nc \
+zip \
+gdb \
+vim \
+unzip \
+which \
+openssl-devel \
+libaio-devel \
+snappy-devel \
+bzip2-devel \
+zlib \
+zlib-devel \
+libzstd-devel \
+lz4-devel \
+bison \
+flex \
+patch; \
Review Comment:
Yes, but its version is low and can't be used for pegasus
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #1011: feat(docker): support centos6 build env
Posted by GitBox <gi...@apache.org>.
foreverneverer commented on code in PR #1011:
URL: https://github.com/apache/incubator-pegasus/pull/1011#discussion_r911710601
##########
docker/pegasus-build-env/centos6/Dockerfile:
##########
@@ -0,0 +1,70 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# use the centos with valid yum repo url
+FROM apachepegasus/centos-vault:6.10
Review Comment:
apachepegasus/centos-vault:6.10 use valid repo url
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org