You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Balázs Bence Sári <bs...@hortonworks.com> on 2017/12/15 15:17:38 UTC
Review Request 64651: Revert adding repo_version column for stack
table.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64651/
-----------------------------------------------------------
Review request for Ambari, Attila Doroszlai, Jayush Luniya, Swapan Shridhar, and Vitalyi Brodetskyi.
Bugs: AMBARI-22297
https://issues.apache.org/jira/browse/AMBARI-22297
Repository: ambari
Description
-------
Stack table does not need the repo_version column, so it should be removed.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StackEntity.java c479cdd427
ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java dc77f19d63
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 84349b6d2f
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql f9d5321e76
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql bc36e35a49
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 227645f1bb
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 333a0c3bc3
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 120bdb60d4
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 4313ae6028
ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 1a8340ab0a
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterImplTest.java d40679aea7
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java 730d51cb98
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 558b334267
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java ca7a7aceb3
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 8568b8c77e
Diff: https://reviews.apache.org/r/64651/diff/1/
Testing
-------
- Fixed related unit tests in ambari-server.
- Unit test run: pending
Thanks,
Balázs Bence Sári
Re: Review Request 64651: Revert adding repo_version column for stack
table.
Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64651/#review193925
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Doroszlai
On Dec. 15, 2017, 4:47 p.m., Balázs Bence Sári wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64651/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2017, 4:47 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Jayush Luniya, Swapan Shridhar, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-22297
> https://issues.apache.org/jira/browse/AMBARI-22297
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Stack table does not need the repo_version column, so it should be removed.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StackEntity.java c479cdd427
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java dc77f19d63
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 84349b6d2f
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql f9d5321e76
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql bc36e35a49
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 227645f1bb
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 333a0c3bc3
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 120bdb60d4
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 4313ae6028
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 1a8340ab0a
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterImplTest.java d40679aea7
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java 730d51cb98
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 558b334267
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java ca7a7aceb3
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 8568b8c77e
>
>
> Diff: https://reviews.apache.org/r/64651/diff/1/
>
>
> Testing
> -------
>
> - Fixed related unit tests in ambari-server.
> - Unit test run: slightly improved unit test results on the feature branch. See below.
>
> Before patch test results:
>
> Tests run: 4946, Failures: 216, Errors: 449, Skipped: 35
>
> After patch test results:
>
> Tests run: 4950, Failures: 216, Errors: 421, Skipped: 35
>
>
> Thanks,
>
> Balázs Bence Sári
>
>
Re: Review Request 64651: Revert adding repo_version column for stack
table.
Posted by Balázs Bence Sári <bs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64651/
-----------------------------------------------------------
(Updated Dec. 15, 2017, 3:47 p.m.)
Review request for Ambari, Attila Doroszlai, Jayush Luniya, Swapan Shridhar, and Vitalyi Brodetskyi.
Bugs: AMBARI-22297
https://issues.apache.org/jira/browse/AMBARI-22297
Repository: ambari
Description
-------
Stack table does not need the repo_version column, so it should be removed.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StackEntity.java c479cdd427
ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java dc77f19d63
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 84349b6d2f
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql f9d5321e76
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql bc36e35a49
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 227645f1bb
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 333a0c3bc3
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 120bdb60d4
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 4313ae6028
ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 1a8340ab0a
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterImplTest.java d40679aea7
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java 730d51cb98
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 558b334267
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java ca7a7aceb3
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 8568b8c77e
Diff: https://reviews.apache.org/r/64651/diff/1/
Testing (updated)
-------
- Fixed related unit tests in ambari-server.
- Unit test run: slightly improved unit test results on the feature branch. See below.
Before patch test results:
Tests run: 4946, Failures: 216, Errors: 449, Skipped: 35
After patch test results:
Tests run: 4950, Failures: 216, Errors: 421, Skipped: 35
Thanks,
Balázs Bence Sári