[GitHub] [arrow-datafusion] jackwener opened a new pull request, #6266: doc: add more sql example in ddl.md

["jackwener (via GitHub)" <gi...@apache.org>]

jackwener opened a new pull request, #6266:
URL: https://github.com/apache/arrow-datafusion/pull/6266

   # Which issue does this PR close?
   
   Closes #.
   
   # Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   # What changes are included in this PR?
   
    add more sql example in ddl.md
   
   # Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   # Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #6266: doc: add more sql example in ddl.md

["comphead (via GitHub)" <gi...@apache.org>]

comphead commented on code in PR #6266:
URL: https://github.com/apache/arrow-datafusion/pull/6266#discussion_r1186744824


##########
docs/source/user-guide/sql/ddl.md:
##########
@@ -156,6 +156,8 @@ CREATE [OR REPLACE] TABLE [IF NOT EXISTS] <b><i>table_name</i></b> AS [SELECT |
 ```sql
 CREATE TABLE IF NOT EXISTS valuetable AS VALUES(1,'HELLO'),(12,'DATAFUSION');
 
+CREATE TABLE IF NOT EXISTS valuetable (c1 INT NOT NULL, c2 VARCHAR NOT NULL) AS VALUES(1,'HELLO'),(12,'DATAFUSION');

Review Comment:
   perhaps its worth to mention that by default column is nullable? or amend the example above to 
   ```
   CREATE TABLE IF NOT EXISTS valuetable AS VALUES(1,'HELLO'),(12,'DATAFUSION'),(null, 'blablabla');
   ```
   
   To highlight the default nullability



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] jackwener merged pull request #6266: doc: add more sql example in ddl.md

["jackwener (via GitHub)" <gi...@apache.org>]

jackwener merged PR #6266:
URL: https://github.com/apache/arrow-datafusion/pull/6266


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org