You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/01/12 11:01:35 UTC
[GitHub] [mynewt-nimble] KKopyscinski opened a new pull request #901: ll: Use macros to compare cputime
KKopyscinski opened a new pull request #901:
URL: https://github.com/apache/mynewt-nimble/pull/901
Time was compared with explicit logic operators and result was casted to
int32_t each time. Now CPUTIME_* macros are used.
This fulfills request in issue https://github.com/apache/mynewt-nimble/issues/356
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #901: ll: Use macros to compare cputime
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek merged pull request #901:
URL: https://github.com/apache/mynewt-nimble/pull/901
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #901: ll: Use macros to compare cputime
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #901:
URL: https://github.com/apache/mynewt-nimble/pull/901#issuecomment-758580879
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/controller/src/ble_ll_conn.c
<details>
```diff
@@ -1160,7 +1159,7 @@
if (CPUTIME_LT(os_cputime_get32() + ticks, next_event_time)) {
md = 1;
}
- }
+ }
/* If we send an empty PDU we need to initialize the header */
conn_tx_pdu:
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #901: ll: Use macros to compare cputime
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #901:
URL: https://github.com/apache/mynewt-nimble/pull/901#issuecomment-758580879
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/controller/src/ble_ll_conn.c
<details>
```diff
@@ -1160,7 +1159,7 @@
if (CPUTIME_LT(os_cputime_get32() + ticks, next_event_time)) {
md = 1;
}
- }
+ }
/* If we send an empty PDU we need to initialize the header */
conn_tx_pdu:
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #901: ll: Use macros to compare cputime
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #901:
URL: https://github.com/apache/mynewt-nimble/pull/901#issuecomment-758582680
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org