You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by rd...@apache.org on 2009/09/16 13:23:52 UTC

svn commit: r815728 - /james/server/trunk/avalon-socket-library/src/main/java/org/apache/james/socket/JamesConnectionBridge.java

Author: rdonkin
Date: Wed Sep 16 11:23:52 2009
New Revision: 815728

URL: http://svn.apache.org/viewvc?rev=815728&view=rev
Log:
JAMES-920 Remove unused methods and make private those methods used only with the class. https://issues.apache.org/jira/browse/JAMES-920

Modified:
    james/server/trunk/avalon-socket-library/src/main/java/org/apache/james/socket/JamesConnectionBridge.java

Modified: james/server/trunk/avalon-socket-library/src/main/java/org/apache/james/socket/JamesConnectionBridge.java
URL: http://svn.apache.org/viewvc/james/server/trunk/avalon-socket-library/src/main/java/org/apache/james/socket/JamesConnectionBridge.java?rev=815728&r1=815727&r2=815728&view=diff
==============================================================================
--- james/server/trunk/avalon-socket-library/src/main/java/org/apache/james/socket/JamesConnectionBridge.java (original)
+++ james/server/trunk/avalon-socket-library/src/main/java/org/apache/james/socket/JamesConnectionBridge.java Wed Sep 16 11:23:52 2009
@@ -138,7 +138,7 @@
      * @param connection The Socket which belongs to the connection 
      * @throws IOException get thrown if an IO error is detected
      */
-    protected void initHandler( Socket connection ) throws IOException {
+    private void initHandler( Socket connection ) throws IOException {
         this.socket = connection;
         remoteIP = socket.getInetAddress().getHostAddress();
         remoteHost = dnsServer.getHostName(socket.getInetAddress());
@@ -255,7 +255,7 @@
         try {
             
             // Do something:
-            handleProtocol();
+            protocolHandler.handleProtocol(this);
             
             log.debug("Closing socket");
         } catch (SocketException se) {
@@ -331,7 +331,7 @@
     /**
      * Idle out this connection
      */
-    void idleClose() {
+    private void idleClose() {
         if (log != null) {
             log.error("Service Connection has idled out.");
         }
@@ -428,20 +428,11 @@
     public String toString() {
         return name;
     }
-    
-    /**
-     * Handle the protocol
-     * 
-     * @throws IOException get thrown if an IO error is detected
-     */
-    public void handleProtocol() throws IOException {
-        protocolHandler.handleProtocol(this);
-    }
 
    /**
     * Resets the handler data to a basic state.
     */
-    public void resetHandler() {
+    private void resetHandler() {
         protocolHandler.resetHandler();
         remoteHost = null;
         remoteIP = null;
@@ -497,13 +488,6 @@
     }
 
     /**
-     * @see org.apache.james.socket.ProtocolContext#getSocket()
-     */
-    public Socket getSocket() {
-        return socket;
-    }
-
-    /**
      * @see org.apache.james.socket.ProtocolContext#getLogger()
      */
     public Log getLogger() {



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org