You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ja...@apache.org on 2022/09/07 02:31:43 UTC
[flink] 03/03: [FLINK-29096][table] Keep backward compatibility of JdbcCatalog constructor
This is an automated email from the ASF dual-hosted git repository.
jark pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit 481ed78bec4211561e78be7586a102bd37a4dfb1
Author: Jark Wu <ja...@apache.org>
AuthorDate: Tue Sep 6 19:50:02 2022 +0800
[FLINK-29096][table] Keep backward compatibility of JdbcCatalog constructor
---
.../flink/connector/jdbc/catalog/JdbcCatalog.java | 36 +++++++++++++++++++---
1 file changed, 31 insertions(+), 5 deletions(-)
diff --git a/flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/JdbcCatalog.java b/flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/JdbcCatalog.java
index 0a9317154cc..fd8a6b5de6c 100644
--- a/flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/JdbcCatalog.java
+++ b/flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/JdbcCatalog.java
@@ -27,19 +27,45 @@ import org.apache.flink.table.catalog.exceptions.CatalogException;
import org.apache.flink.table.catalog.exceptions.DatabaseNotExistException;
import org.apache.flink.table.catalog.exceptions.TableNotExistException;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
import java.util.List;
/** Catalogs for relational databases via JDBC. */
@PublicEvolving
public class JdbcCatalog extends AbstractJdbcCatalog {
- private static final Logger LOG = LoggerFactory.getLogger(JdbcCatalog.class);
-
private final AbstractJdbcCatalog internal;
+ /**
+ * Creates a JdbcCatalog.
+ *
+ * @deprecated please use {@link JdbcCatalog#JdbcCatalog(ClassLoader, String, String, String,
+ * String, String)} instead.
+ */
+ public JdbcCatalog(
+ String catalogName,
+ String defaultDatabase,
+ String username,
+ String pwd,
+ String baseUrl) {
+ this(
+ Thread.currentThread().getContextClassLoader(),
+ catalogName,
+ defaultDatabase,
+ username,
+ pwd,
+ baseUrl);
+ }
+
+ /**
+ * Creates a JdbcCatalog.
+ *
+ * @param userClassLoader the classloader used to load JDBC driver
+ * @param catalogName the registered catalog name
+ * @param defaultDatabase the default database name
+ * @param username the username used to connect the database
+ * @param pwd the password used to connect the database
+ * @param baseUrl the base URL of the database, e.g. jdbc:mysql://localhost:3306
+ */
public JdbcCatalog(
ClassLoader userClassLoader,
String catalogName,