You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/08/24 08:22:24 UTC
[GitHub] [kafka] kowshik opened a new pull request #11253: MINOR: Improve local variable name in UnifiedLog.maybeIncrementFirstUnstableOffset
kowshik opened a new pull request #11253:
URL: https://github.com/apache/kafka/pull/11253
It looked odd that the code has a local variable named `updatedFirstStableOffset` which is used to update `MergedLog.firstUnstableOffsetMetadata`. This PR improves the local variable name to be `updatedFirstUnstableOffset` instead which is more aligned with the `MergedLog` attribute being updated.
**Tests:**
Relying on existing unit & integration tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kowshik commented on pull request #11253: MINOR: Improve local variable name in UnifiedLog.maybeIncrementFirstUnstableOffset
Posted by GitBox <gi...@apache.org>.
kowshik commented on pull request #11253:
URL: https://github.com/apache/kafka/pull/11253#issuecomment-906698169
cc @lbradstreet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] junrao merged pull request #11253: MINOR: Improve local variable name in UnifiedLog.maybeIncrementFirstUnstableOffset
Posted by GitBox <gi...@apache.org>.
junrao merged pull request #11253:
URL: https://github.com/apache/kafka/pull/11253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kowshik commented on pull request #11253: MINOR: Improve local variable name in UnifiedLog.maybeIncrementFirstUnstableOffset
Posted by GitBox <gi...@apache.org>.
kowshik commented on pull request #11253:
URL: https://github.com/apache/kafka/pull/11253#issuecomment-905142894
cc @junrao @ijuma for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org