[GitHub] [accumulo] ctubbsii commented on a change in pull request #1000: Simplified options in ClientOpts

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #1000: Simplified options in ClientOpts
URL: https://github.com/apache/accumulo/pull/1000#discussion_r262159016
 
 

 ##########
 File path: test/src/main/java/org/apache/accumulo/test/RewriteTabletDirectoriesIT.java
 ##########
 @@ -124,8 +124,10 @@ public void test() throws Exception {
         assertEquals(splits.size() + 1, count);
 
         // This should fail: only one volume
-        assertEquals(1, cluster.exec(RandomizeVolumes.class, "-z", cluster.getZooKeepers(), "-i",
-            getClientInfo().getInstanceName(), "-t", tableName).getProcess().waitFor());
+        assertEquals(1,
+            cluster
+                .exec(RandomizeVolumes.class, "-c", cluster.getClientPropsPath(), "-t", tableName)
+                .getProcess().waitFor());
 
 Review comment:
   Could force it by disabling the formatter, but I think the formatter is making the correct choice here... it's trying to not split up the second parameter too much. Because the second param is so long, though, it starts on the next line to highlight the fact that it's the start of a new param, rather than part of previous params.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services