You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/15 20:07:13 UTC
[GitHub] [airflow] potiuk opened a new pull request #14812: Pin SQLAlchemy to <1.4 due to breakage of sqlalchemy-utils
potiuk opened a new pull request #14812:
URL: https://github.com/apache/airflow/pull/14812
The 1.4 releae of SQLAlchemy breaks sqlalchemy-utils.
This change pins it to < 1.4
Fixes #14811
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #14812: Pin SQLAlchemy to <1.4 due to breakage of sqlalchemy-utils
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #14812:
URL: https://github.com/apache/airflow/pull/14812
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14812: Pin SQLAlchemy to <1.4 due to breakage of sqlalchemy-utils
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14812:
URL: https://github.com/apache/airflow/pull/14812#issuecomment-825728620
https://github.com/pallets/flask-sqlalchemy/pull/955
And https://github.com/sqlalchemy/sqlalchemy/issues/6285
So it's not _just_ that module anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hugohadlow-globality commented on pull request #14812: Pin SQLAlchemy to <1.4 due to breakage of sqlalchemy-utils
Posted by GitBox <gi...@apache.org>.
hugohadlow-globality commented on pull request #14812:
URL: https://github.com/apache/airflow/pull/14812#issuecomment-825726932
sqlalchemy-utils 0.37.0 (2021-04-12) now supports sqlalchemy 1.4.
"Added SQLAlchemy 1.4 support"
https://github.com/kvesteri/sqlalchemy-utils/blob/master/CHANGES.rst
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #14812: Pin SQLAlchemy to <1.4 due to breakage of sqlalchemy-utils
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14812:
URL: https://github.com/apache/airflow/pull/14812#issuecomment-800604253
Not really. It won't change anything for already released versions. But if you use constraints it will work fine. This is why we have constraints and this is the only way we recommend installing airflow
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] xinbinhuang commented on pull request #14812: Pin SQLAlchemy to <1.4 due to breakage of sqlalchemy-utils
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on pull request #14812:
URL: https://github.com/apache/airflow/pull/14812#issuecomment-800596053
Will need to merge this to the 1.10.* series. Currently, it's still breaking on installation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] xinbinhuang commented on pull request #14812: Pin SQLAlchemy to <1.4 due to breakage of sqlalchemy-utils
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on pull request #14812:
URL: https://github.com/apache/airflow/pull/14812#issuecomment-800734846
> Not really. It won't change anything for already released versions. But if you use constraints it will work fine. This is why we have constraints and this is the only way we recommend installing airflow
I totally forget about the constraints. thanks for the tips!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org