You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/02 18:06:21 UTC

[GitHub] [airflow] msb217 commented on issue #7596: [AIRFLOW-6870] [WIP] remove imports from models/__init__.py

msb217 commented on issue #7596: [AIRFLOW-6870] [WIP] remove imports from models/__init__.py
URL: https://github.com/apache/airflow/pull/7596#issuecomment-593537042
 
 
   @potiuk @nuclearpinguin I've addressed the majority of your comments, however, considering the size of this PR and sanity's sake - would you like me close PR to break this down into separate PRs and Jira issues?
   
   For example:
   1. Implement `resetdb` and `all_models` case
   2. Change module path for `DAG` to `from airflow import DAG` for `example_dags`
   3. Change paths to model modules
   4. Pre-commit hooks to be done by either of you guys
   
   I just don't want to drive you guys insane with such a large review :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services