[GitHub] thrift pull request #1172: THRIFT-4060 add better support in the cpp generat...

[hcorg <gi...@git.apache.org>]

Github user hcorg commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1172#discussion_r100583307
  
    --- Diff: lib/cpp/test/AnnotationTest.cpp ---
    @@ -0,0 +1,73 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements. See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership. The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License. You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied. See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +#define BOOST_TEST_MODULE AnnotationTest
    +#include <boost/test/unit_test.hpp>
    +#include "gen-cpp/AnnotationTest_types.h"
    +#include <ostream>
    +#include <sstream>
    +
    +// Normally thrift generates ostream operators, however
    +// with the annotation "cpp.customostream" one can tell the
    +// compiler they are going to provide their own, and not
    +// emit operator << or printTo().
    +
    +std::ostream& operator<<(std::ostream& os, const ostr_custom& osc)
    +{
    +  os << "{ bar = " << osc.bar << "; }";
    +  return os;
    +}
    +
    +BOOST_AUTO_TEST_SUITE(BOOST_TEST_MODULE)
    +
    +BOOST_AUTO_TEST_CASE(test_cpp_customostream) {
    +  //
    +  // Show the compiler generated ostream operator does something..
    +  //
    +
    +  ostr_default def;
    +  def.__set_bar(10);
    +
    +  std::stringstream ssd;
    +  ssd << def;
    +  BOOST_CHECK_EQUAL(ssd.str(), "ostr_default(bar=10)");
    +
    +  //
    +  // Now show that if cpp.customostream is added as an annotation,
    +  // the behavior can be overridden in a safe and usable way (THRIFT-4060).
    +  //
    +
    +  ostr_custom cus;
    +  cus.__set_bar(10);
    +
    +  std::stringstream csd;
    +  csd << cus;
    +  BOOST_CHECK_EQUAL(csd.str(), "{ bar = 10; }");
    --- End diff --
    
    IMHO its better to keep "single test-case - single test" (or AAA or GivenWhenThen scheme). This file could include couple of SUITES (for example - one per annotation, and then well-named tests). Anytime I see comment I try to find a way to remade code so it does not need that comment ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---