You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/23 14:01:36 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #10867:
[FLINK-14701][runtime] Fix MultiTaskSlot to not remove slots which are not
its children
tillrohrmann commented on a change in pull request #10867: [FLINK-14701][runtime] Fix MultiTaskSlot to not remove slots which are not its children
URL: https://github.com/apache/flink/pull/10867#discussion_r370131977
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java
##########
@@ -612,7 +612,9 @@ private void releaseChild(AbstractID childGroupId) {
TaskSlot child = children.remove(childGroupId);
if (child != null) {
- allTaskSlots.remove(child.getSlotRequestId());
+ if (child == allTaskSlots.get(child.getSlotRequestId())) {
+ allTaskSlots.remove(child.getSlotRequestId());
+ }
Review comment:
I would actually make this a precondition in the master branch because the original problem occurred because we were reusing `SlotRequestIds` which were never intended for this purpose. In the `release-1.9` branch, we can keep it like it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services