You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yuluo-yx (via GitHub)" <gi...@apache.org> on 2026/08/08 06:37:41 UTC

[PR] [ISSUE #10832] fix(remoting): reject malformed command frames [rocketmq]

yuluo-yx opened a new pull request, #10842:
URL: https://github.com/apache/rocketmq/pull/10842

   ### Which Issue(s) This PR Fixes
   
   - Fixes #10832
   
   ### Brief Description
   
   Reject short command frames and unknown serialization types with `RemotingCommandException` instead of unchecked exceptions.
   
   ### How Did You Test This Change?
   
   - `mise x java@temurin-17 -- mvn -pl remoting -am -Dtest=RemotingCommandTest -Dsurefire.failIfNoSpecifiedTests=false test`
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #10832] fix(remoting): reject malformed command frames [rocketmq]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10842:
URL: https://github.com/apache/rocketmq/pull/10842#issuecomment-5225053405

   ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/10842?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 48.31%. Comparing base ([`fd0c959`](https://app.codecov.io/gh/apache/rocketmq/commit/fd0c95920e0deac96ce2ae27442747cc5e65e930?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4b85579`](https://app.codecov.io/gh/apache/rocketmq/commit/4b855797bd3f9800628a45552691ebf729af63e8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop   #10842      +/-   ##
   =============================================
   - Coverage      48.37%   48.31%   -0.06%     
   + Complexity     13555    13537      -18     
   =============================================
     Files           1380     1380              
     Lines         101165   101170       +5     
     Branches       13127    13129       +2     
   =============================================
   - Hits           48940    48884      -56     
   - Misses         46250    46300      +50     
   - Partials        5975     5986      +11     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/rocketmq/pull/10842?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #10832] fix(remoting): reject malformed command frames [rocketmq]

Posted by "yuluo-yx (via GitHub)" <gi...@apache.org>.
yuluo-yx closed pull request #10842: [ISSUE #10832] fix(remoting): reject malformed command frames
URL: https://github.com/apache/rocketmq/pull/10842


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org