You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/10 22:41:14 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26817:
[SPARK-30192][SQL] support column position in DS v2
dongjoon-hyun commented on a change in pull request #26817: [SPARK-30192][SQL] support column position in DS v2
URL: https://github.com/apache/spark/pull/26817#discussion_r356317574
##########
File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableChange.java
##########
@@ -259,6 +298,60 @@ public int hashCode() {
}
}
+ interface ColumnPosition {
+ First FIRST = new First();
+
+ static ColumnPosition After(String[] column) {
Review comment:
Can we have a different function name, @cloud-fan ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org