You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Yulei-Yang (via GitHub)" <gi...@apache.org> on 2023/11/28 02:57:35 UTC
[PR] [Improvement](unset_variable) add docs for unset-variable stmt and update privilege check [doris]
Yulei-Yang opened a new pull request, #27672:
URL: https://github.com/apache/doris/pull/27672
1. add docs md
2. check admin privilege when unset global
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Improvement](unset_variable) add docs for unset-variable stmt and update privilege check [doris]
Posted by "lide-reed (via GitHub)" <gi...@apache.org>.
lide-reed merged PR #27672:
URL: https://github.com/apache/doris/pull/27672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Improvement](unset_variable) add docs for unset-variable stmt and update privilege check [doris]
Posted by "nextdreamblue (via GitHub)" <gi...@apache.org>.
nextdreamblue commented on PR #27672:
URL: https://github.com/apache/doris/pull/27672#issuecomment-1829181058
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Improvement](unset_variable) add docs for unset-variable stmt and update privilege check [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27672:
URL: https://github.com/apache/doris/pull/27672#issuecomment-1829113519
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 7f50644cf60ef8c536198b8c64aa553d67b3cd6d, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4904 4654 4619 4619
q2 366 149 158 149
q3 2067 1918 1949 1918
q4 1412 1302 1289 1289
q5 3905 3940 3971 3940
q6 262 128 130 128
q7 1371 831 843 831
q8 2782 2814 2765 2765
q9 10108 9672 9622 9622
q10 3435 3525 3496 3496
q11 380 241 249 241
q12 439 288 310 288
q13 4543 3828 3805 3805
q14 319 293 298 293
q15 591 546 528 528
q16 514 458 470 458
q17 1152 991 956 956
q18 7897 7481 7365 7365
q19 1669 1661 1681 1661
q20 593 493 299 299
q21 4422 4014 4017 4014
q22 456 374 382 374
Total cold run time: 53587 ms
Total hot run time: 49039 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4599 4595 4567 4567
q2 351 247 264 247
q3 4037 4010 3986 3986
q4 2723 2699 2704 2699
q5 9582 9559 9712 9559
q6 246 124 121 121
q7 2955 2436 2510 2436
q8 4458 4467 4494 4467
q9 13230 13122 13098 13098
q10 4082 4154 4175 4154
q11 759 699 668 668
q12 979 803 809 803
q13 4322 3562 3568 3562
q14 380 374 342 342
q15 583 531 512 512
q16 596 580 564 564
q17 3817 3890 3962 3890
q18 9639 9129 9208 9129
q19 1815 1784 1774 1774
q20 2376 2062 2051 2051
q21 8867 8705 8588 8588
q22 910 814 827 814
Total cold run time: 81306 ms
Total hot run time: 78031 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Improvement](unset_variable) add docs for unset-variable stmt and update privilege check [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27672:
URL: https://github.com/apache/doris/pull/27672#issuecomment-1829019234
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Improvement](unset_variable) add docs for unset-variable stmt and update privilege check [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27672:
URL: https://github.com/apache/doris/pull/27672#issuecomment-1829102631
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.61 seconds
stream load tsv: 578 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.5 seconds inserted 10000000 Rows, about 350K ops/s
storage size: 17103414081 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Improvement](unset_variable) add docs for unset-variable stmt and update privilege check [doris]
Posted by "Yulei-Yang (via GitHub)" <gi...@apache.org>.
Yulei-Yang commented on PR #27672:
URL: https://github.com/apache/doris/pull/27672#issuecomment-1828985854
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Improvement](unset_variable) add docs for unset-variable stmt and update privilege check [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27672:
URL: https://github.com/apache/doris/pull/27672#issuecomment-1829019210
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org