You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by JoshRosen <gi...@git.apache.org> on 2015/06/01 05:51:49 UTC

[GitHub] spark pull request: [HOT FIX] [BUILD] Fix maven build failures

Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/6511#issuecomment-107300035
  
    I'm running into Maven build breaks due to missing test-jar dependencies in the `sql`, `mllib` and `flume-sink` projects.  Why did you remove the test dependency?  I can understand that it wouldn't transitively inherit the test deps. of a project that it depends on, but what's the harm in explicitly adding a test dep? Also, why do you think that the Jenkins build didn't catch the local Maven test compilation issues that I saw when running make-distribution.sh?  Do you think that this is something that's Maven version specific?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org