[jira] [Closed] (ARTEMIS-1955) Not all AMQP headers are mapped in AMQPCoreConverter

["Timothy Bish (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-1955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish closed ARTEMIS-1955.
---------------------------------
    Resolution: Not A Problem

The method "populateMessage" which is called right in the bit of code you copied encodes the "Header" and "Properties" sections into the message as expected. 

> Not all AMQP headers are mapped in AMQPCoreConverter
> ----------------------------------------------------
>
>                 Key: ARTEMIS-1955
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1955
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: AMQP
>    Affects Versions: 2.6.2
>            Reporter: Simon Chalmers
>            Priority: Major
>
> From here:
> https://github.com/apache/activemq-artemis/blob/2c8b6b4aee7b03f2872f04f1d8caaa9d85436216/artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/AmqpCoreConverter.java#L111-L177
> It doesn't look like you're NOT mapping all the available AMQP headers to your internal message representation, specifically you're only doing 4 out of ~20
> Your set:
> populateMessage(result, message.getProtonMessage());
> result.getInnerMessage().setReplyTo(message.getReplyTo());
> result.getInnerMessage().setDurable(message.isDurable());
> result.getInnerMessage().setPriority(message.getPriority());
> result.getInnerMessage().setAddress(message.getAddressSimpleString());
> The full header set for AMQP: http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-messaging-v1.0-os.html#section-message-format
> So if someone were expecting their AMQP headers to be carried across, they would be lost.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)