You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "AryanVBW (via GitHub)" <gi...@apache.org> on 2025/03/12 07:43:36 UTC
[PR] Add Dark Mode Support [kvrocks-website]
AryanVBW opened a new pull request, #281:
URL: https://github.com/apache/kvrocks-website/pull/281
This pull request contains several modifications to enhance the dark mode support and the visual coherence of the website. The most significant changes are to allow the color mode switch, updating dark mode styles, and introducing new CSS variables for color tuning.
Enhancements to dark mode support:
* [`docusaurus.config.js`](diffhunk://#diff-a038096cbdea434999e1dce5ab497212f1fe18204dde1a027ce3bdd663261a2aL70-R71): Enabled the color mode switch and added support for respecting the user's preferred color scheme.
* [`src/css/custom.css`](diffhunk://#diff-44813f307e729042af7e70beff6f32ea63a7941bc100043a49e84d229ea2570fR10-R37): Added dark mode overrides for primary colors, background colors, and other UI elements.
Updates to component styles:
* [`src/components/HomepageFeatures/index.tsx`](diffhunk://#diff-9cace34abd690449cb771cf041513cd4b624ebd34921f2cf69e23b183bd59877L55-R55): Updated the title element to use a new CSS class for consistent styling.
* [`src/components/HomepageFeatures/styles.module.css`](diffhunk://#diff-974d2f1dcc3826170a5f1aacfbbde839b4928a259eb7b664a4c161e70824b1dcR53-R56): Added dark mode styles for various elements, including descriptions and titles. [[1]](diffhunk://#diff-974d2f1dcc3826170a5f1aacfbbde839b4928a259eb7b664a4c161e70824b1dcR53-R56) [[2]](diffhunk://#diff-974d2f1dcc3826170a5f1aacfbbde839b4928a259eb7b664a4c161e70824b1dcR120-R135)
Improvements to homepage styles:
* [`src/pages/index.module.css`](diffhunk://#diff-d88ca19240bc4f47684fbd8108114ccbab409c5e48f93069f2e6567222b20b92R16-R19): Added dark mode styles for the hero banner, titles, taglines, and buttons to ensure readability and visual appeal. [[1]](diffhunk://#diff-d88ca19240bc4f47684fbd8108114ccbab409c5e48f93069f2e6567222b20b92R16-R19) [[2]](diffhunk://#diff-d88ca19240bc4f47684fbd8108114ccbab409c5e48f93069f2e6567222b20b92R32-R40) [[3]](diffhunk://#diff-d88ca19240bc4f47684fbd8108114ccbab409c5e48f93069f2e6567222b20b92R52-R55) [[4]](diffhunk://#diff-d88ca19240bc4f47684fbd8108114ccbab409c5e48f93069f2e6567222b20b92R104-R123)
* [`src/pages/index.tsx`](diffhunk://#diff-18e0d4553c97cfc420e938ccafb4e3a688e782fa4512ba4ceae3e2a6f24c1987L15-R15): Removed inline styling for the hero title to use the new CSS classes for better maintainability.
https://github.com/user-attachments/assets/d5326d12-f766-4f11-a61b-4a47b1844c9b
@PragmaTwice @git-hulk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Dark Mode Support [kvrocks-website]
Posted by "AryanVBW (via GitHub)" <gi...@apache.org>.
AryanVBW commented on PR #281:
URL: https://github.com/apache/kvrocks-website/pull/281#issuecomment-2721472643
> > It looks fine, but I think icons like ‘Namespace’ and ‘Cluster’ would look better without a white background so they can automatically match the theme color. Also, the user logos on the User page don’t look good because they blend with the background. I was considering using SVG icons so they adapt to the theme color.
>
> Yeah it's better to improve these icons.
Sir, please check it out, I have updated it. https://github.com/apache/kvrocks-website/pull/283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Dark Mode Support [kvrocks-website]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice merged PR #281:
URL: https://github.com/apache/kvrocks-website/pull/281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Dark Mode Support [kvrocks-website]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #281:
URL: https://github.com/apache/kvrocks-website/pull/281#issuecomment-2717084997
The banner part looks good to me. How about these icons below the banner?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Dark Mode Support [kvrocks-website]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #281:
URL: https://github.com/apache/kvrocks-website/pull/281#issuecomment-2718065233
> It looks fine, but I think icons like ‘Namespace’ and ‘Cluster’ would look better without a white background so they can automatically match the theme color. Also, the user logos on the User page don’t look good because they blend with the background. I was considering using SVG icons so they adapt to the theme color.
Yeah it's better to improve these icons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Dark Mode Support [kvrocks-website]
Posted by "AryanVBW (via GitHub)" <gi...@apache.org>.
AryanVBW commented on PR #281:
URL: https://github.com/apache/kvrocks-website/pull/281#issuecomment-2717790890
> The banner part looks good to me. How about these icons below the banner?
Hi Sir, are you talking about these four banners?
<img width="1780" alt="icon bellow banner " src="https://github.com/user-attachments/assets/ff15a15a-0e5e-48a4-a778-c5c885fac8f7" />
It looks fine, but I think icons like ‘Namespace’ and ‘Cluster’ would look better without a white background so they can automatically match the theme color. Also, the user logos on the User page don’t look good because they blend with the background. I was considering using SVG icons so they adapt to the theme color, but I need approval first. Can I proceed with this change?
https://github.com/user-attachments/assets/d0fb6e02-aee4-4cf7-ad1a-71ed70828016
**This is overall site look**
https://github.com/user-attachments/assets/e3d358bf-837b-41c8-8c8d-f77d13d967e3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org