You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/28 05:03:51 UTC

[GitHub] [shardingsphere] sandynz commented on a change in pull request #7076: Fix PostgreSQL authentication NullPointerException

sandynz commented on a change in pull request #7076:
URL: https://github.com/apache/shardingsphere/pull/7076#discussion_r478831860



##########
File path: shardingsphere-db-protocol/shardingsphere-db-protocol-postgresql/src/main/java/org/apache/shardingsphere/db/protocol/postgresql/packet/handshake/PostgreSQLAuthenticationMD5PasswordPacket.java
##########
@@ -29,6 +29,7 @@
     
     private static final int AUTH_REQ_MD5 = 5;
     
+    @Getter

Review comment:
       It's called in `PostgreSQLAuthenticationEngineTest`, since `md5Salt` is generated random bytes in `PostgreSQLAuthenticationEngine`, test case will get this `md5Salt` to calculate `md5Digest` for login.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org