You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tapestry.apache.org by "Jochen Kemnade (JIRA)" <ji...@apache.org> on 2015/02/18 10:13:12 UTC

[jira] [Commented] (TAP5-2446) Use ObjectCreator instead of PerThreadValue when appropriate

    [ https://issues.apache.org/jira/browse/TAP5-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14325625#comment-14325625 ] 

Jochen Kemnade commented on TAP5-2446:
--------------------------------------

The patch looks good, thanks! I just learned about {{org.apache.tapestry5.ioc.services.PerthreadManager.createValue(ObjectCreator<T>)}} yesterday.
I'll turn the anonymous {{ObjectCreator}} implementation in {{PageImpl}} into a nested one though, so we don't create a new class for each page. The Worker is a singleton so there's only one class one way or the other.

> Use ObjectCreator instead of PerThreadValue when appropriate
> ------------------------------------------------------------
>
>                 Key: TAP5-2446
>                 URL: https://issues.apache.org/jira/browse/TAP5-2446
>             Project: Tapestry 5
>          Issue Type: Sub-task
>          Components: tapestry-core
>            Reporter: Michael Mikhulya
>              Labels: patch, performance
>         Attachments: 0001-Use-ObjectCreator-instead-of-PerThreadValue-when-app.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)