You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/10 09:57:44 UTC
[GitHub] [kafka] jiameixie opened a new pull request #8845: KAFKA-10126:Warn unused ConsumerPerformance optons
jiameixie opened a new pull request #8845:
URL: https://github.com/apache/kafka/pull/8845
Option numThreadsOpt and numFetchersOpt are unused in ConsumerPerformance.
According to comments from https://issues.apache.org/jira/browse/KAFKA-10126,
add a warning when invoking these options which should be recognized
Change-Id: Iae34b11210a361373eda42274ebfc153b636a989
Signed-off-by: Jiamei Xie <ji...@arm.com>
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jiameixie commented on pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance
Posted by GitBox <gi...@apache.org>.
jiameixie commented on pull request #8845:
URL: https://github.com/apache/kafka/pull/8845#issuecomment-645194668
@ijuma Call for review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda commented on pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance
Posted by GitBox <gi...@apache.org>.
abbccdda commented on pull request #8845:
URL: https://github.com/apache/kafka/pull/8845#issuecomment-648449655
Having tested 3 * 3 times, and only flaky test failed such as this one:
https://issues.apache.org/jira/browse/KAFKA-9509
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jiameixie commented on pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance
Posted by GitBox <gi...@apache.org>.
jiameixie commented on pull request #8845:
URL: https://github.com/apache/kafka/pull/8845#issuecomment-641924051
@abbccdda @chia7712 @ijuma Call for review. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda commented on pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance
Posted by GitBox <gi...@apache.org>.
abbccdda commented on pull request #8845:
URL: https://github.com/apache/kafka/pull/8845#issuecomment-648241834
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda merged pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance
Posted by GitBox <gi...@apache.org>.
abbccdda merged pull request #8845:
URL: https://github.com/apache/kafka/pull/8845
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda commented on pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance
Posted by GitBox <gi...@apache.org>.
abbccdda commented on pull request #8845:
URL: https://github.com/apache/kafka/pull/8845#issuecomment-647904244
Only one flaky test failed:
```
kafka.api.PlaintextAdminIntegrationTest.testConsumerGroups
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda commented on pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance
Posted by GitBox <gi...@apache.org>.
abbccdda commented on pull request #8845:
URL: https://github.com/apache/kafka/pull/8845#issuecomment-647904275
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jiameixie commented on pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance
Posted by GitBox <gi...@apache.org>.
jiameixie commented on pull request #8845:
URL: https://github.com/apache/kafka/pull/8845#issuecomment-642361238
@abbccdda @chia7712 Thanks for your advice. I have updated it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #8845:
URL: https://github.com/apache/kafka/pull/8845#discussion_r438267308
##########
File path: core/src/main/scala/kafka/tools/ConsumerPerformance.scala
##########
@@ -232,12 +232,12 @@ object ConsumerPerformance extends LazyLogging {
.describedAs("size")
.ofType(classOf[java.lang.Integer])
.defaultsTo(2 * 1024 * 1024)
- val numThreadsOpt = parser.accepts("threads", "Number of processing threads.")
+ val numThreadsOpt = parser.accepts("threads", "Number of processing threads. It has not been implemented.")
Review comment:
https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/tools/GetOffsetShell.scala#L55 had similar issue and we can follow its style. i.e ```DEPRECATED AND IGNORED:```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda commented on a change in pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance
Posted by GitBox <gi...@apache.org>.
abbccdda commented on a change in pull request #8845:
URL: https://github.com/apache/kafka/pull/8845#discussion_r439877376
##########
File path: core/src/main/scala/kafka/tools/ConsumerPerformance.scala
##########
@@ -256,6 +256,10 @@ object ConsumerPerformance extends LazyLogging {
.defaultsTo(10000)
options = parser.parse(args: _*)
+
+ if(options.has(numThreadsOpt) || options.has(numFetchersOpt))
+ println("WARNING: option threads and num-fetch-threads have been deprecated and ignored")
Review comment:
nit: add square brackets to the options, like:
```
"WARNING: option [threads] and [num-fetch-threads] have been deprecated and will be ignored by the test"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda commented on pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance
Posted by GitBox <gi...@apache.org>.
abbccdda commented on pull request #8845:
URL: https://github.com/apache/kafka/pull/8845#issuecomment-648242282
Also failed:
```
kafka.api.PlaintextAdminIntegrationTest.testAlterReplicaLogDirs
org.scalatest.exceptions.TestFailedException: only 0 messages are produced within timeout after replica movement. Producer future Some(Failure(java.util.concurrent.TimeoutException: Timeout after waiting for 10000 ms.))
at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:530)
at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:529)
at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1389)
at org.scalatest.Assertions.fail(Assertions.scala:1091)
at org.scalatest.Assertions.fail$(Assertions.scala:1087)
at org.scalatest.Assertions$.fail(Assertions.scala:1389)
at kafka.api.PlaintextAdminIntegrationTest.testAlterReplicaLogDirs(PlaintextAdminIntegrationTest.scala:289)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:564)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288)
at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.lang.Thread.run(Thread.java:830)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda commented on pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance
Posted by GitBox <gi...@apache.org>.
abbccdda commented on pull request #8845:
URL: https://github.com/apache/kafka/pull/8845#issuecomment-647739314
test this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jiameixie commented on pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance
Posted by GitBox <gi...@apache.org>.
jiameixie commented on pull request #8845:
URL: https://github.com/apache/kafka/pull/8845#issuecomment-647240367
@abbccdda @chia7712 Could you merge this PR please？Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda commented on a change in pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance
Posted by GitBox <gi...@apache.org>.
abbccdda commented on a change in pull request #8845:
URL: https://github.com/apache/kafka/pull/8845#discussion_r438320972
##########
File path: core/src/main/scala/kafka/tools/ConsumerPerformance.scala
##########
@@ -232,12 +232,12 @@ object ConsumerPerformance extends LazyLogging {
.describedAs("size")
.ofType(classOf[java.lang.Integer])
.defaultsTo(2 * 1024 * 1024)
- val numThreadsOpt = parser.accepts("threads", "Number of processing threads.")
+ val numThreadsOpt = parser.accepts("threads", "Number of processing threads. It has not been implemented.")
Review comment:
+1
##########
File path: core/src/main/scala/kafka/tools/ConsumerPerformance.scala
##########
@@ -256,6 +256,10 @@ object ConsumerPerformance extends LazyLogging {
.defaultsTo(10000)
options = parser.parse(args: _*)
+
+ if(options.has(numThreadsOpt) || options.has(numFetchersOpt))
+ println("WARNING: option threads and num-fetch-threads has not been implemented.")
Review comment:
`has not been implemented` -> `have been deprecated`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org