You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/13 08:09:37 UTC
[GitHub] [pulsar] Technoboy- commented on pull request #18007: [fix][broker] In the setAcknowledgedPosition method, when newMarkDeletePosition is equal to markDeletePosition, an exception is thrown
Technoboy- commented on PR #18007:
URL: https://github.com/apache/pulsar/pull/18007#issuecomment-1277206906
> Does this mean, before this change, user can `ack` the same messageId repeatedly without getting exception. But with this change, user will get an exception?
The user will not get any exceptions.
https://github.com/apache/pulsar/blob/c73285205dafaf5bed827ad99f7fb8edd3ddb7f2/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java#L390-L391
https://github.com/apache/pulsar/blob/c73285205dafaf5bed827ad99f7fb8edd3ddb7f2/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java#L444-L464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org