You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/06 17:03:19 UTC

[GitHub] [airflow] riastrad commented on pull request #22767: add new S3MultiKeySensor

riastrad commented on PR #22767:
URL: https://github.com/apache/airflow/pull/22767#issuecomment-1090498519

   Thank you both for the quick responses!
   
   @o-nikolas:
   1. Thanks for heads up about doc updates. If we decide to move forward with this PR then I'll be sure to add those.
   2. Our use case currently only requires 3 checks, but might need to expand to more in the future. We had considered using multiple sensors with a downstream trigger rule like you described, but our DAGs are already quite complicated and a custom sensor that only represented one task felt like the cleaner solution in this case.
   
   @eladkal thank you for flagging #22737! I didn't see that when I initially skimmed PRs in this repo. A quick look at those changes and I agree that they should satisfy our use case quite well if/when they land in main. 
   
   I'm definitely happy to close this PR out in favor of #22737, since that appears to be a more robust solution 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org