You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/03/15 08:41:44 UTC

[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1594: fix: CI failed

Jaycean commented on a change in pull request #1594:
URL: https://github.com/apache/apisix-dashboard/pull/1594#discussion_r594141065



##########
File path: api/internal/core/entity/entity.go
##########
@@ -81,7 +81,7 @@ type Route struct {
 	Hosts           []string               `json:"hosts,omitempty"`
 	RemoteAddr      string                 `json:"remote_addr,omitempty"`
 	RemoteAddrs     []string               `json:"remote_addrs,omitempty"`
-	Vars            interface{}            `json:"vars,omitempty"`
+	Vars            []interface{}          `json:"vars,omitempty"`

Review comment:
       Why should the data format be modified here? Whether it has influence on the existing FE and BE logic.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org