You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2008/02/19 08:20:50 UTC
DO NOT REPLY [Bug 44450] New: - [patch] Added implementations for VLOOKUP and HLOOKUP
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44450>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=44450
Summary: [patch] Added implementations for VLOOKUP and HLOOKUP
Product: POI
Version: 3.0-dev
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P2
Component: HSSF
AssignedTo: dev@poi.apache.org
ReportedBy: josh@gildedtree.com
Also added a very basic implementation of LOOKUP and refactored much code in
MATCH.
Two files added in 44403 were also added in this patch
EvaluationException.java OperandResolver.java. The content is identical.
One file modified in 44449 (ValueRecordsAggregate.java) has a 'hack' of that
same bug-fix made in this patch. The version from patch 44449 is much better.
New junit TestLookupFunctionsFromSpreadsheet and a dedicated test data
spreadsheet were added to test specific behaviour of these test cases more
thoroughly.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 44450] - [patch] Added implementations for VLOOKUP and HLOOKUP
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44450>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=44450
nick@torchbox.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #21556|0 |1
is obsolete| |
------- Additional Comments From nick@torchbox.com 2008-02-21 08:03 -------
Created an attachment (id=21574)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=21574&action=view)
Svn patch showing what was applied vs trunk when the tests failed
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 44450] - [patch] Added implementations for VLOOKUP and HLOOKUP
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44450>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=44450
nick@torchbox.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
------- Additional Comments From nick@torchbox.com 2008-02-21 08:02 -------
This is blowing up for me, on test
org.apache.poi.hssf.record.formula.functions.TestLookupFunctionsFromSpreadsheet
[junit] Testcase: testFunctionsFromTestSpreadsheet took 1.284 sec
[junit] FAILED
[junit] 5 sheets(s) failed with 68 evaluation(s). There were 0 successful
sheets(s) and 1 function(s) without error
[junit] junit.framework.AssertionFailedError: 5 sheets(s) failed with 68
evaluation(s). There were 0 successful sheets(s) and 1 function(s) without error
[junit] at
org.apache.poi.hssf.record.formula.functions.TestLookupFunctionsFromSpreadsheet.testFunctionsFromTestSpreadsheet(TestLookupFunctionsFromSpreadsheet.java:216)
I'll attach a svn diff so you can see what I have and haven't applied. Any
chance you could spot what's gone wrong?
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 44450] - [patch] Added implementations for VLOOKUP and HLOOKUP
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44450>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=44450
nick@torchbox.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
------- Additional Comments From nick@torchbox.com 2008-02-22 03:24 -------
Thanks, this new version applied nicely and tests all passed.
I've committed it to svn trunk
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 44450] - [patch] Added implementations for VLOOKUP and HLOOKUP
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44450>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=44450
------- Additional Comments From josh@gildedtree.com 2008-02-18 23:25 -------
Created an attachment (id=21556)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=21556&action=view)
svn diff of 8 modified files
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 44450] - [patch] Added implementations for VLOOKUP and HLOOKUP
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44450>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=44450
------- Additional Comments From josh@gildedtree.com 2008-02-21 12:58 -------
On first inspection it looks like the edits for Vlookup.java and Hlookup.java
didn't make it through. It is probably easier for me just to re-do this
patch, since there were a lot of POI changes applied recently.
While working on a future patch (regarding formula parsing) I found a better
home for the raw excel error codes stuff - HSSFErrorConstants. For the re-do
of this patch (44450) I re-worked the error code related stuff accordingly.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 44450] - [patch] Added implementations for VLOOKUP and HLOOKUP
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44450>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=44450
------- Additional Comments From josh@gildedtree.com 2008-02-18 23:26 -------
Created an attachment (id=21557)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=21557&action=view)
tar bz2 of 5 new files (2 identical to those added in patch 44403)
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 44450] - [patch] Added implementations for VLOOKUP and HLOOKUP
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44450>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=44450
josh@gildedtree.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #21574|0 |1
is obsolete| |
------- Additional Comments From josh@gildedtree.com 2008-02-21 13:01 -------
Created an attachment (id=21576)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=21576&action=view)
svn diff of 9 changed files
- Added implementation for HLOOKUP, VLOOKUP, and LOOKUP. Refactored Match to
use LookupUtils.
- Found a better home for constants class ErrorEval.ErrorCode. Merged
functionality with HSSFErrorConstants. ErrPtg updated.
- Added javadoc on StringValueEval, and null check in StringEval constructor.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 44450] - [patch] Added implementations for VLOOKUP and HLOOKUP
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44450>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=44450
josh@gildedtree.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #21557|0 |1
is obsolete| |
------- Additional Comments From josh@gildedtree.com 2008-02-21 13:02 -------
Created an attachment (id=21577)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=21577&action=view)
tar bz2 of 3 added files
LookupUtils.java
TestLookupFunctionsFromSpreadsheet.java
LookupFunctionsTestCaseData.xls
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org