You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/12/15 16:43:07 UTC
[GitHub] [iceberg] aokolnychyi opened a new pull request #3753: Core: Use consistent literal definition in TableProperties
aokolnychyi opened a new pull request #3753:
URL: https://github.com/apache/iceberg/pull/3753
This PR unifies the definition style of our constants in `TableProperties`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #3753: Core: Use consistent literal definition in TableProperties
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #3753:
URL: https://github.com/apache/iceberg/pull/3753#issuecomment-995065225
Thanks, @RussellSpitzer @kbendick!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on a change in pull request #3753: Core: Use consistent literal definition in TableProperties
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #3753:
URL: https://github.com/apache/iceberg/pull/3753#discussion_r769862029
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -69,13 +69,13 @@ private TableProperties() {
public static final long COMMIT_STATUS_CHECKS_MIN_WAIT_MS_DEFAULT = 1000L; // 1s
public static final String COMMIT_STATUS_CHECKS_MAX_WAIT_MS = "commit.status-check.max-wait-ms";
- public static final long COMMIT_STATUS_CHECKS_MAX_WAIT_MS_DEFAULT = 60000L; // 1 minute
+ public static final long COMMIT_STATUS_CHECKS_MAX_WAIT_MS_DEFAULT = 60 * 1000L; // 1 minute
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi merged pull request #3753: Core: Use consistent literal definition in TableProperties
Posted by GitBox <gi...@apache.org>.
aokolnychyi merged pull request #3753:
URL: https://github.com/apache/iceberg/pull/3753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on a change in pull request #3753: Core: Use consistent literal definition in TableProperties
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #3753:
URL: https://github.com/apache/iceberg/pull/3753#discussion_r769860422
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -69,13 +69,13 @@ private TableProperties() {
public static final long COMMIT_STATUS_CHECKS_MIN_WAIT_MS_DEFAULT = 1000L; // 1s
public static final String COMMIT_STATUS_CHECKS_MAX_WAIT_MS = "commit.status-check.max-wait-ms";
- public static final long COMMIT_STATUS_CHECKS_MAX_WAIT_MS_DEFAULT = 60000L; // 1 minute
+ public static final long COMMIT_STATUS_CHECKS_MAX_WAIT_MS_DEFAULT = 60 * 1000L; // 1 minute
Review comment:
Agree, let me drop L here and in one more place like this for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #3753: Core: Use consistent literal definition in TableProperties
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #3753:
URL: https://github.com/apache/iceberg/pull/3753#issuecomment-994973529
cc @szehon-ho @flyrain @RussellSpitzer @karuppayya @rdblue @kbendick @jackye1995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #3753: Core: Use consistent literal definition in TableProperties
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on a change in pull request #3753:
URL: https://github.com/apache/iceberg/pull/3753#discussion_r769810538
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -69,13 +69,13 @@ private TableProperties() {
public static final long COMMIT_STATUS_CHECKS_MIN_WAIT_MS_DEFAULT = 1000L; // 1s
public static final String COMMIT_STATUS_CHECKS_MAX_WAIT_MS = "commit.status-check.max-wait-ms";
- public static final long COMMIT_STATUS_CHECKS_MAX_WAIT_MS_DEFAULT = 60000L; // 1 minute
+ public static final long COMMIT_STATUS_CHECKS_MAX_WAIT_MS_DEFAULT = 60 * 1000L; // 1 minute
Review comment:
Not sure why we included the L here, this is the smallest multiplication we do among these literals :) I think we could just remove it now, or maybe we should add L on all the constants if we are afraid of overflows ... Doesn't really matter to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org