You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Bernd Bohmann (JIRA)" <de...@myfaces.apache.org> on 2007/01/15 15:56:27 UTC

[jira] Commented: (TOBAGO-240) tc:popup rendered attribute disabled (tc:popup not useable anymore)

    [ https://issues.apache.org/jira/browse/TOBAGO-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464818 ] 

Bernd Bohmann commented on TOBAGO-240:
--------------------------------------

The usage of the popup has simplified. You don't need to set the rendered attribute for the Popup. 
For the 1.0.10 release we have restored some of the behavor before 1.0.9.

If the popup is a pupup facet of a button it is automatic rendered if the button is clicked.

A good example is the sheet config dialog of the sheetControl.jsp in tobago-example-demo. 

> tc:popup rendered attribute disabled (tc:popup not useable anymore)
> -------------------------------------------------------------------
>
>                 Key: TOBAGO-240
>                 URL: https://issues.apache.org/jira/browse/TOBAGO-240
>             Project: MyFaces Tobago
>          Issue Type: Bug
>    Affects Versions: 1.0.9
>         Environment: suse 10.0 myfaces 1.1.2 and jsf-ri 1.2 
>            Reporter: Richard van Nieuwenhoven
>
> we just switched to Tobago 1.0.9 and we discovered that the rendered attribute of the popup is not evaluated anymore. worse still is almost not possible to use popups from a page without the access to UIPopup class itself.
> The reason it that the isRendered method on the UIPopup is overwritten and it checks if the last action on the page is compatible with the action inside the popup (ignoring the superclass implementation that evaluates my expression) ... in case of manual popups it will never succeed....
> In the demo application the popup is also not functional anymore, probably for the same reason.
> Is it intended use that the popup should not be used anymore or is this a major bug?
> regards,
> Ritchie

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [jira] Commented: (TOBAGO-240) tc:popup rendered attribute disabled (tc:popup not useable anymore)

Posted by Bernd Bohmann <be...@atanion.com>.
Hello Stojan,

you can test it with the current snapshot.

Regards

Bernd

Volker Weber wrote:
> Hi Stojan,
> 
> there is (should) no difference in opening popups from menu, toolbar,
> link or button components.
> 
> if there is only one command component which opens this popup just
> attach the popup facet inside the command. If you need to open the
> same popup from different places, e.g. from menu and toolbar, you can
> use the popupreferece tag.
> http://myfaces.apache.org/tobago/tobago-core/tlddoc/tc/popupReference.html
> 
> Regards,
>  Volker
> 
> 2007/1/18, goodusername <go...@gmail.com>:
>> What about the case of opening the popup thru the menu?
>> We had menuItem with an action that toggled the showPopup boolean (used
>> by a popup renderer)
>> Now my menu popups are not working anymore
>> I tried using the attribute <tc:attribute name="renderedPartially" .. >
>> with the menuItem, but still no success.
>> Any workaround on this one, please?
>>
>> btw. I also have similar problem as Richard with the popups used as a
>> message dialogs...
>>
>> Thanks
>> Stojan
>>
>> Bernd Bohmann (JIRA) wrote:
>> >     [ 
>> https://issues.apache.org/jira/browse/TOBAGO-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464818 
>> ]
>> >
>> > Bernd Bohmann commented on TOBAGO-240:
>> > --------------------------------------
>> >
>> > The usage of the popup has simplified. You don't need to set the 
>> rendered attribute for the Popup.
>> > For the 1.0.10 release we have restored some of the behavor before 
>> 1.0.9.
>> >
>> > If the popup is a pupup facet of a button it is automatic rendered 
>> if the button is clicked.
>> >
>> > A good example is the sheet config dialog of the sheetControl.jsp in 
>> tobago-example-demo.
>> >
>> >
>>
>>
> 

Re: [jira] Commented: (TOBAGO-240) tc:popup rendered attribute disabled (tc:popup not useable anymore)

Posted by Volker Weber <we...@googlemail.com>.
Just adding a example to gendoc:
http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-tool/gendoc/src/main/webapp/screenshot/popup.jsp?view=markup

2007/1/18, Volker Weber <we...@googlemail.com>:
> Hi Stojan,
>
> there is (should) no difference in opening popups from menu, toolbar,
> link or button components.
>
> if there is only one command component which opens this popup just
> attach the popup facet inside the command. If you need to open the
> same popup from different places, e.g. from menu and toolbar, you can
> use the popupreferece tag.
> http://myfaces.apache.org/tobago/tobago-core/tlddoc/tc/popupReference.html
>
> Regards,
>   Volker
>
> 2007/1/18, goodusername <go...@gmail.com>:
> > What about the case of opening the popup thru the menu?
> > We had menuItem with an action that toggled the showPopup boolean (used
> > by a popup renderer)
> > Now my menu popups are not working anymore
> > I tried using the attribute <tc:attribute name="renderedPartially" .. >
> > with the menuItem, but still no success.
> > Any workaround on this one, please?
> >
> > btw. I also have similar problem as Richard with the popups used as a
> > message dialogs...
> >
> > Thanks
> > Stojan
> >
> > Bernd Bohmann (JIRA) wrote:
> > >     [ https://issues.apache.org/jira/browse/TOBAGO-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464818 ]
> > >
> > > Bernd Bohmann commented on TOBAGO-240:
> > > --------------------------------------
> > >
> > > The usage of the popup has simplified. You don't need to set the rendered attribute for the Popup.
> > > For the 1.0.10 release we have restored some of the behavor before 1.0.9.
> > >
> > > If the popup is a pupup facet of a button it is automatic rendered if the button is clicked.
> > >
> > > A good example is the sheet config dialog of the sheetControl.jsp in tobago-example-demo.
> > >
> > >
> >
> >
>

Re: [jira] Commented: (TOBAGO-240) tc:popup rendered attribute disabled (tc:popup not useable anymore)

Posted by Volker Weber <we...@googlemail.com>.
Hi Stojan,

there is (should) no difference in opening popups from menu, toolbar,
link or button components.

if there is only one command component which opens this popup just
attach the popup facet inside the command. If you need to open the
same popup from different places, e.g. from menu and toolbar, you can
use the popupreferece tag.
http://myfaces.apache.org/tobago/tobago-core/tlddoc/tc/popupReference.html

Regards,
  Volker

2007/1/18, goodusername <go...@gmail.com>:
> What about the case of opening the popup thru the menu?
> We had menuItem with an action that toggled the showPopup boolean (used
> by a popup renderer)
> Now my menu popups are not working anymore
> I tried using the attribute <tc:attribute name="renderedPartially" .. >
> with the menuItem, but still no success.
> Any workaround on this one, please?
>
> btw. I also have similar problem as Richard with the popups used as a
> message dialogs...
>
> Thanks
> Stojan
>
> Bernd Bohmann (JIRA) wrote:
> >     [ https://issues.apache.org/jira/browse/TOBAGO-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464818 ]
> >
> > Bernd Bohmann commented on TOBAGO-240:
> > --------------------------------------
> >
> > The usage of the popup has simplified. You don't need to set the rendered attribute for the Popup.
> > For the 1.0.10 release we have restored some of the behavor before 1.0.9.
> >
> > If the popup is a pupup facet of a button it is automatic rendered if the button is clicked.
> >
> > A good example is the sheet config dialog of the sheetControl.jsp in tobago-example-demo.
> >
> >
>
>

Re: [jira] Commented: (TOBAGO-240) tc:popup rendered attribute disabled (tc:popup not useable anymore)

Posted by goodusername <go...@gmail.com>.
What about the case of opening the popup thru the menu?
We had menuItem with an action that toggled the showPopup boolean (used 
by a popup renderer)
Now my menu popups are not working anymore
I tried using the attribute <tc:attribute name="renderedPartially" .. >  
with the menuItem, but still no success.
Any workaround on this one, please?

btw. I also have similar problem as Richard with the popups used as a 
message dialogs...

Thanks
Stojan

Bernd Bohmann (JIRA) wrote:
>     [ https://issues.apache.org/jira/browse/TOBAGO-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464818 ] 
>
> Bernd Bohmann commented on TOBAGO-240:
> --------------------------------------
>
> The usage of the popup has simplified. You don't need to set the rendered attribute for the Popup. 
> For the 1.0.10 release we have restored some of the behavor before 1.0.9.
>
> If the popup is a pupup facet of a button it is automatic rendered if the button is clicked.
>
> A good example is the sheet config dialog of the sheetControl.jsp in tobago-example-demo. 
>
>