[GitHub] [knox] smolnar82 commented on a change in pull request #371: KNOX-2408 - Improved AliasBasedTokenState service and house-keeping

[GitBox <gi...@apache.org>]

smolnar82 commented on a change in pull request #371:
URL: https://github.com/apache/knox/pull/371#discussion_r480077126



##########
File path: gateway-server/src/test/java/org/apache/knox/gateway/services/token/impl/AliasBasedTokenStateServiceTest.java
##########
@@ -195,7 +204,8 @@ public void testAddAndRemoveTokenIncludesCache() throws Exception {
    * Verify that the token state reaper includes token state which has not been cached, so it's not left in the keystore
    * forever.
    */
-  @Test
+  @Ignore("I'm not sure if this is a valid use case since we have everything in the cache when eviction takes place")

Review comment:
       @pzampino As you can see I only ignored this test case for now because I'm not sure if it makes sense going forward. Since the eviction thread checks everything in the cache we may remove this test case. What do you think?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org