[GitHub] [cloudstack] rafaelweingartner commented on pull request #4668: Adjust tests to fix a problem with the container builders (https://github.com/khos2ow/cloudstack-deb-builder)

[GitBox <gi...@apache.org>]

rafaelweingartner commented on pull request #4668:
URL: https://github.com/apache/cloudstack/pull/4668#issuecomment-785794401


   @weizhouapache the problem we discovered was found with Java8. Anyways, the goal here is to patch a poorly coded test that is breaking Java8 docker build. Anybody that look at the code will see that it is not using mock properly. Instead, the unit test case is "mockig" via manual reflection. We need to patch this on 4.13, so we can fix the build of the docker build images with Java8; these images are validated with the latest Java8 ACS version.  Then, @GutoVeronezi is introducing a new docker build configuration that uses Java11 there as well, which will be validated with Java11.
   
   Why does the test only breaks on OpenJDK8? We have no idea, when I reviewed and saw the test cases, my OCD kicked in, ant that was the first thing fixed. When we tested again, it worked. Anyways, I will merge this one later today. It is a simple patch that is fixing a test case that was poorly written. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org