You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Harish Butani <rh...@gmail.com> on 2013/12/18 02:57:17 UTC

Review Request 16338: HIVE-5615: Subquery support: more tests

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16338/
-----------------------------------------------------------

Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-5615
    https://issues.apache.org/jira/browse/HIVE-5615


Repository: hive-git


Description
-------

Subquery support: more tests


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/QBSubQuery.java b9c7e6f 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java b9cd65c 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java 8c03c7d 
  ql/src/test/org/apache/hadoop/hive/ql/parse/TestQBSubQuery.java PRE-CREATION 
  ql/src/test/queries/clientnegative/subquery_shared_alias.q PRE-CREATION 
  ql/src/test/queries/clientnegative/subquery_unqual_corr_expr.q PRE-CREATION 
  ql/src/test/queries/clientpositive/subquery_views.q PRE-CREATION 
  ql/src/test/results/clientnegative/subquery_shared_alias.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/subquery_unqual_corr_expr.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/subquery_views.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/16338/diff/


Testing
-------

added more testing for views.
Added api level testing for SQUtils methods.
Better error reporting.
Added 2 new explicit checks: Restriction 16, 17.


Thanks,

Harish Butani