You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "gruuya (via GitHub)" <gi...@apache.org> on 2024/01/17 11:00:14 UTC
[PR] Add support for Postgres LIKE operators [arrow-datafusion]
gruuya opened a new pull request, #8894:
URL: https://github.com/apache/arrow-datafusion/pull/8894
## Which issue does this PR close?
Closes #8893.
## Rationale for this change
Add support for Postgres `~~`, `~~*`, `!~~`, `!~~*` like-pattern operators, in analogy with the regex-matching operators `~`, `~*`, `!~`, `!~*`.
## What changes are included in this PR?
Extend the `Operator` enum with the new variants, and wire-up evaluation for them.
## Are these changes tested?
Yes.
## Are there any user-facing changes?
New operators available to be used in querying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for Postgres LIKE operators [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #8894:
URL: https://github.com/apache/arrow-datafusion/pull/8894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for Postgres LIKE operators [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #8894:
URL: https://github.com/apache/arrow-datafusion/pull/8894#issuecomment-1910992916
https://github.com/apache/arrow-datafusion/pull/9000 has the sqlparser upgrade
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for Postgres LIKE operators [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #8894:
URL: https://github.com/apache/arrow-datafusion/pull/8894#discussion_r1466821074
##########
Cargo.toml:
##########
@@ -70,7 +70,7 @@ parquet = { version = "50.0.0", default-features = false, features = ["arrow", "
rand = "0.8"
rstest = "0.18.0"
serde_json = "1"
-sqlparser = { version = "0.41.0", features = ["visitor"] }
+sqlparser = { git = "https://github.com/sqlparser-rs/sqlparser-rs", rev = "c7d2903c6d1d1a98e6e6203c5cfd54acb9aeca16", features = ["visitor"] }
Review Comment:
I think we need to wait for sqlparser to be released -- see https://github.com/sqlparser-rs/sqlparser-rs/issues/1074 prior to merging this. However I plan to work on releasing sqlparser later today so I think we should be good shortly
##########
docs/source/user-guide/sql/operators.md:
##########
@@ -263,6 +263,58 @@ Not Regex Case-Insensitive Match
+---------------------------------------------------+
```
+### `~~`
Review Comment:
❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for Postgres LIKE operators [arrow-datafusion]
Posted by "gruuya (via GitHub)" <gi...@apache.org>.
gruuya commented on code in PR #8894:
URL: https://github.com/apache/arrow-datafusion/pull/8894#discussion_r1467424060
##########
Cargo.toml:
##########
@@ -70,7 +70,7 @@ parquet = { version = "50.0.0", default-features = false, features = ["arrow", "
rand = "0.8"
rstest = "0.18.0"
serde_json = "1"
-sqlparser = { version = "0.41.0", features = ["visitor"] }
+sqlparser = { git = "https://github.com/sqlparser-rs/sqlparser-rs", rev = "c7d2903c6d1d1a98e6e6203c5cfd54acb9aeca16", features = ["visitor"] }
Review Comment:
Thanks, that was quick!
I've merged the latest main into this branch now, let me know if there's anything else to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for Postgres LIKE operators [arrow-datafusion]
Posted by "gruuya (via GitHub)" <gi...@apache.org>.
gruuya commented on PR #8894:
URL: https://github.com/apache/arrow-datafusion/pull/8894#issuecomment-1895578266
DRAFT as it's dependent on https://github.com/sqlparser-rs/sqlparser-rs/pull/1096 getting merged first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org