You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Bryan Pendleton (JIRA)" <ji...@apache.org> on 2009/10/02 01:21:23 UTC
[jira] Created: (DERBY-4394) Add documentation for ROLLUP
functionality in GROUP BY clause
Add documentation for ROLLUP functionality in GROUP BY clause
-------------------------------------------------------------
Key: DERBY-4394
URL: https://issues.apache.org/jira/browse/DERBY-4394
Project: Derby
Issue Type: Sub-task
Reporter: Bryan Pendleton
Assignee: Bryan Pendleton
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4394) Add documentation for ROLLUP
functionality in GROUP BY clause
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Pendleton updated DERBY-4394:
-----------------------------------
Attachment: useBraces.diff
rrefsqlj32654.html
Thanks Knut! I was all tripped up between braces and square brackets; I think the page looks cleaner now.
> Add documentation for ROLLUP functionality in GROUP BY clause
> -------------------------------------------------------------
>
> Key: DERBY-4394
> URL: https://issues.apache.org/jira/browse/DERBY-4394
> Project: Derby
> Issue Type: Sub-task
> Reporter: Bryan Pendleton
> Assignee: Bryan Pendleton
> Attachments: addSyntaxAndExample.diff, fixIntentationOfExample.diff, rrefsqlj32654.html, rrefsqlj32654.html, rrefsqlj32654.html, useBraces.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4394) Add documentation for ROLLUP
functionality in GROUP BY clause
Posted by "Kim Haase (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766550#action_12766550 ]
Kim Haase commented on DERBY-4394:
----------------------------------
Actually -- sorry I missed this before -- but shouldn't it be just one set of curly braces, with the two choices (separated by the OR bar) inside?
GROUP BY
{ column-Name [ , column-Name ]* |
ROLLUP ( column-Name [ , column-Name ]* ) }
> Add documentation for ROLLUP functionality in GROUP BY clause
> -------------------------------------------------------------
>
> Key: DERBY-4394
> URL: https://issues.apache.org/jira/browse/DERBY-4394
> Project: Derby
> Issue Type: Sub-task
> Reporter: Bryan Pendleton
> Assignee: Bryan Pendleton
> Attachments: addSyntaxAndExample.diff, fixIntentationOfExample.diff, rrefsqlj32654.html, rrefsqlj32654.html, rrefsqlj32654.html, useBraces.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4394) Add documentation for ROLLUP
functionality in GROUP BY clause
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766008#action_12766008 ]
Knut Anders Hatlen commented on DERBY-4394:
-------------------------------------------
In the syntax description, it looks like some square brackets have been misplaced so that the entire list of column names has been made optional. Using { and } for grouping may also make the syntax easier to read. I suggest something like this:
GROUP BY
{ column-Name [ , column-Name ]* } |
{ ROLLUP ( column-Name [ , column-Name ]* ) }
The sentence starting with "Using the ROLLUP syntax" lacks a full stop. Perhaps it's better to say "ROLLUP keyword" instead of "ROLLUP syntax" too?
The existing examples use upper case SQL statements. For consistency, we may want to use upper case in the new example too.
> Add documentation for ROLLUP functionality in GROUP BY clause
> -------------------------------------------------------------
>
> Key: DERBY-4394
> URL: https://issues.apache.org/jira/browse/DERBY-4394
> Project: Derby
> Issue Type: Sub-task
> Reporter: Bryan Pendleton
> Assignee: Bryan Pendleton
> Attachments: addSyntaxAndExample.diff, fixIntentationOfExample.diff, rrefsqlj32654.html, rrefsqlj32654.html
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4394) Add documentation for ROLLUP
functionality in GROUP BY clause
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Pendleton updated DERBY-4394:
-----------------------------------
Attachment: rrefsqlj32654.html
addSyntaxAndExample.diff
Attached is a tiny docs patch which simply adds the new syntax and a trivial
example to the GROUP BY page in the reference manual.
The updated HTML page is attached for easier review.
> Add documentation for ROLLUP functionality in GROUP BY clause
> -------------------------------------------------------------
>
> Key: DERBY-4394
> URL: https://issues.apache.org/jira/browse/DERBY-4394
> Project: Derby
> Issue Type: Sub-task
> Reporter: Bryan Pendleton
> Assignee: Bryan Pendleton
> Attachments: addSyntaxAndExample.diff, rrefsqlj32654.html
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4394) Add documentation for ROLLUP
functionality in GROUP BY clause
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766454#action_12766454 ]
Knut Anders Hatlen commented on DERBY-4394:
-------------------------------------------
Thanks Bryan, the latest patch looks great! +1 to commit.
> Add documentation for ROLLUP functionality in GROUP BY clause
> -------------------------------------------------------------
>
> Key: DERBY-4394
> URL: https://issues.apache.org/jira/browse/DERBY-4394
> Project: Derby
> Issue Type: Sub-task
> Reporter: Bryan Pendleton
> Assignee: Bryan Pendleton
> Attachments: addSyntaxAndExample.diff, fixIntentationOfExample.diff, rrefsqlj32654.html, rrefsqlj32654.html, rrefsqlj32654.html, useBraces.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-4394) Add documentation for ROLLUP
functionality in GROUP BY clause
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Pendleton resolved DERBY-4394.
------------------------------------
Resolution: Fixed
Fix Version/s: 10.6.0.0
Committed to the docs trunk as svn revision 826126,
> Add documentation for ROLLUP functionality in GROUP BY clause
> -------------------------------------------------------------
>
> Key: DERBY-4394
> URL: https://issues.apache.org/jira/browse/DERBY-4394
> Project: Derby
> Issue Type: Sub-task
> Reporter: Bryan Pendleton
> Assignee: Bryan Pendleton
> Fix For: 10.6.0.0
>
> Attachments: addSyntaxAndExample.diff, fixIntentationOfExample.diff, rrefsqlj32654.html, rrefsqlj32654.html, rrefsqlj32654.html, rrefsqlj32654.html, useBraces.diff, useBracesDifferently.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4394) Add documentation for ROLLUP
functionality in GROUP BY clause
Posted by "Kim Haase (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765629#action_12765629 ]
Kim Haase commented on DERBY-4394:
----------------------------------
This looks great, Bryan. Thanks for separating out the existing examples too.
You might want to left-align the second line of each of the last two comments -- it looks odd indented.
> Add documentation for ROLLUP functionality in GROUP BY clause
> -------------------------------------------------------------
>
> Key: DERBY-4394
> URL: https://issues.apache.org/jira/browse/DERBY-4394
> Project: Derby
> Issue Type: Sub-task
> Reporter: Bryan Pendleton
> Assignee: Bryan Pendleton
> Attachments: addSyntaxAndExample.diff, rrefsqlj32654.html
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4394) Add documentation for ROLLUP
functionality in GROUP BY clause
Posted by "Kim Haase (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766632#action_12766632 ]
Kim Haase commented on DERBY-4394:
----------------------------------
This looks just fine.
I'm amazed you found any near-consistent model to base your syntax diagram on, but you picked a good readable one.
> Add documentation for ROLLUP functionality in GROUP BY clause
> -------------------------------------------------------------
>
> Key: DERBY-4394
> URL: https://issues.apache.org/jira/browse/DERBY-4394
> Project: Derby
> Issue Type: Sub-task
> Reporter: Bryan Pendleton
> Assignee: Bryan Pendleton
> Attachments: addSyntaxAndExample.diff, fixIntentationOfExample.diff, rrefsqlj32654.html, rrefsqlj32654.html, rrefsqlj32654.html, rrefsqlj32654.html, useBraces.diff, useBracesDifferently.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4394) Add documentation for ROLLUP
functionality in GROUP BY clause
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Pendleton updated DERBY-4394:
-----------------------------------
Attachment: useBracesDifferently.diff
rrefsqlj32654.html
Thanks Kim and Knut for the continued review and assistance.
I agree with Kim's latest comment: only one set of braces seems needed.
I took a look at a couple of the other pages in the ref guide, and tried to
structure things so that the syntax diagram is more similar to those other pages.
> Add documentation for ROLLUP functionality in GROUP BY clause
> -------------------------------------------------------------
>
> Key: DERBY-4394
> URL: https://issues.apache.org/jira/browse/DERBY-4394
> Project: Derby
> Issue Type: Sub-task
> Reporter: Bryan Pendleton
> Assignee: Bryan Pendleton
> Attachments: addSyntaxAndExample.diff, fixIntentationOfExample.diff, rrefsqlj32654.html, rrefsqlj32654.html, rrefsqlj32654.html, rrefsqlj32654.html, useBraces.diff, useBracesDifferently.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4394) Add documentation for ROLLUP
functionality in GROUP BY clause
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Pendleton updated DERBY-4394:
-----------------------------------
Attachment: fixIntentationOfExample.diff
rrefsqlj32654.html
Thanks Kim! I fixed the indentation of the comments in the examples section.
> Add documentation for ROLLUP functionality in GROUP BY clause
> -------------------------------------------------------------
>
> Key: DERBY-4394
> URL: https://issues.apache.org/jira/browse/DERBY-4394
> Project: Derby
> Issue Type: Sub-task
> Reporter: Bryan Pendleton
> Assignee: Bryan Pendleton
> Attachments: addSyntaxAndExample.diff, fixIntentationOfExample.diff, rrefsqlj32654.html, rrefsqlj32654.html
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.