mod_ssl input filtering WAS Re: [PATCH] Re: PHP Apache2Filter

[Justin Erenkrantz <je...@ebuilt.com>]

On Sun, Jan 20, 2002 at 10:59:54AM -0800, Doug MacEachern wrote:
> On Sun, 20 Jan 2002, Justin Erenkrantz wrote:
>  
> > Also, be aware that the *readbytes may change to readbytes.  I
> > don't know who has commit access to PHP, but it'd be nice if
> > someone over there applied the following for now.  =)  -- justin
> 
> i've adjusted modperl and php (with the same fix as your patch) just a few
> minutes ago.  nice work btw, makes things much cleaner.

Cool.  Thanks.

Oh, also, mod_ssl may want to take advantage of the new
apr_brigade_split_line call (see how core_input_filter calls it).
I'm rewriting ap_rgetline in my tree, so things are sort of a mess
in my tree.  But, it should ease the complexity a bit.  What do you
think about that?  I know that was one of your complaints in the
recent input filtering changes in mod_ssl.  -- justin

Re: mod_ssl input filtering WAS Re: [PATCH] Re: PHP Apache2Filter

[Doug MacEachern <do...@covalent.net>]

On Sun, 20 Jan 2002, Justin Erenkrantz wrote:
 
> Oh, also, mod_ssl may want to take advantage of the new
> apr_brigade_split_line call (see how core_input_filter calls it).
> I'm rewriting ap_rgetline in my tree, so things are sort of a mess
> in my tree.  But, it should ease the complexity a bit.  What do you
> think about that?  I know that was one of your complaints in the
> recent input filtering changes in mod_ssl.  -- justin

sounds great to me.