[GitHub] [cassandra] sumanth-pasupuleti commented on a change in pull request #1043: Obfuscate password for DCL statements in QueryEvents

[GitBox <gi...@apache.org>]

sumanth-pasupuleti commented on a change in pull request #1043:
URL: https://github.com/apache/cassandra/pull/1043#discussion_r646775367



##########
File path: src/java/org/apache/cassandra/cql3/QueryEvents.java
##########
@@ -72,8 +82,9 @@ public void notifyQuerySuccess(CQLStatement statement,
     {
         try
         {
+
             for (Listener listener : listeners)
-                listener.querySuccess(statement, query, options, state, queryTime, response);
+                listener.querySuccess(statement, possiblyObfuscateQuery(statement, query), options, state, queryTime, response);

Review comment:
       Updating based on our offline conversation
   
   - In most practical scenarios, one would either have no / one listener configured in which case, it is better we do obfuscation inside the forloop vs outside, since if it is outside, independent of whether there are any listeners, we do the obfuscation once.
   - In case of > 1 listener, performance penalty of having multiple listeners is likely to exceed an additional round of obfuscation




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org