[lucene-solr] branch reference_impl_dev updated: @1026 Update note.

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

markrmiller pushed a commit to branch reference_impl_dev
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/reference_impl_dev by this push:
     new d2f1fdd  @1026 Update note.
d2f1fdd is described below

commit d2f1fdd5240c123e13cbf193bb963d1bc3b024ef
Author: markrmiller@gmail.com <ma...@gmail.com>
AuthorDate: Sat Oct 17 19:58:15 2020 -0500

    @1026 Update note.
---
 solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java b/solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java
index 82e4cec..6ca4a7d 100644
--- a/solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java
+++ b/solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java
@@ -99,7 +99,8 @@ public class SolrZkClient implements Closeable {
 
   private ZkCmdExecutor zkCmdExecutor;
 
-  // what about ensuring order of state updates per collection??
+  // TODO: this is less efficient now, only using a single thread - allowing multiple threads leaves room for out of order cluster state updates
+  // TODO: could allow parallel by collection?
   final ExecutorService zkCallbackExecutor = ParWork.getParExecutorService("zkCallbackExecutor", 1, 1, 10000, new BlockingArrayQueue());
 
   final ExecutorService zkConnManagerCallbackExecutor = ParWork.getParExecutorService("zkConnManagerCallbackExecutor",1, 1, 60000, new BlockingArrayQueue());