You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org> on 2019/08/21 17:21:21 UTC
[Impala-ASF-CR] IMPALA-8864: Ignore fe http transport tests on older python versions
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14116
Change subject: IMPALA-8864: Ignore fe http transport tests on older python versions
......................................................................
IMPALA-8864: Ignore fe http transport tests on older python versions
A follow up commit on IMPALA-8864. A couple of fe junit tests also
run shell hs2-http tests that are failing on older python versions.
This patch identifies such older python versions and skips the
problematic tests.
Change-Id: I1449965ba6eb1bca0e64c56065c453ed8c7c46a7
---
M fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
1 file changed, 28 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/14116/1
--
To view, visit http://gerrit.cloudera.org:8080/14116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1449965ba6eb1bca0e64c56065c453ed8c7c46a7
Gerrit-Change-Number: 14116
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
[Impala-ASF-CR] IMPALA-8864: Ignore fe http transport tests on older python versions
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14116 )
Change subject: IMPALA-8864: Ignore fe http transport tests on older python versions
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4826/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1449965ba6eb1bca0e64c56065c453ed8c7c46a7
Gerrit-Change-Number: 14116
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Aug 2019 17:28:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8864: Ignore fe http transport tests on older python versions
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14116 )
Change subject: IMPALA-8864: Ignore fe http transport tests on older python versions
......................................................................
IMPALA-8864: Ignore fe http transport tests on older python versions
A follow up commit on IMPALA-8864. A couple of fe junit tests also
run shell hs2-http tests that are failing on older python versions.
This patch identifies such older python versions and skips the
problematic tests.
Change-Id: I1449965ba6eb1bca0e64c56065c453ed8c7c46a7
Reviewed-on: http://gerrit.cloudera.org:8080/14116
Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
1 file changed, 28 insertions(+), 4 deletions(-)
Approvals:
Thomas Tauber-Marshall: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1449965ba6eb1bca0e64c56065c453ed8c7c46a7
Gerrit-Change-Number: 14116
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-8864: Ignore fe http transport tests on older python versions
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14116 )
Change subject: IMPALA-8864: Ignore fe http transport tests on older python versions
......................................................................
Patch Set 1: Code-Review-2
Thanks for the quick review. I'm temporarily marking this as a -2 until my private CentOs6 build finishes. Want to be sure that this fix works as intended.
--
To view, visit http://gerrit.cloudera.org:8080/14116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1449965ba6eb1bca0e64c56065c453ed8c7c46a7
Gerrit-Change-Number: 14116
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Aug 2019 20:48:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8864: Ignore fe http transport tests on older python versions
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14116 )
Change subject: IMPALA-8864: Ignore fe http transport tests on older python versions
......................................................................
Patch Set 1:
I'm running a private build on centos6. Also kicking off a GVO.
--
To view, visit http://gerrit.cloudera.org:8080/14116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1449965ba6eb1bca0e64c56065c453ed8c7c46a7
Gerrit-Change-Number: 14116
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Aug 2019 17:28:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8864: Ignore fe http transport tests on older python versions
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14116 )
Change subject: IMPALA-8864: Ignore fe http transport tests on older python versions
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1449965ba6eb1bca0e64c56065c453ed8c7c46a7
Gerrit-Change-Number: 14116
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Aug 2019 19:42:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8864: Ignore fe http transport tests on older python versions
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14116 )
Change subject: IMPALA-8864: Ignore fe http transport tests on older python versions
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1449965ba6eb1bca0e64c56065c453ed8c7c46a7
Gerrit-Change-Number: 14116
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Aug 2019 21:33:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8864: Ignore fe http transport tests on older python versions
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has removed a vote on this change.
Change subject: IMPALA-8864: Ignore fe http transport tests on older python versions
......................................................................
Removed Code-Review-2 by Bharath Vissapragada <bh...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/14116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I1449965ba6eb1bca0e64c56065c453ed8c7c46a7
Gerrit-Change-Number: 14116
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-8864: Ignore fe http transport tests on older python versions
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14116 )
Change subject: IMPALA-8864: Ignore fe http transport tests on older python versions
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4321/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1449965ba6eb1bca0e64c56065c453ed8c7c46a7
Gerrit-Change-Number: 14116
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Aug 2019 18:02:08 +0000
Gerrit-HasComments: No