You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/15 14:33:15 UTC
[GitHub] [spark] gengliangwang opened a new pull request #32918: [SPARK-35766][SQL][TESTS] Break down CastSuite/AnsiCastSuite into multiple files
gengliangwang opened a new pull request #32918:
URL: https://github.com/apache/spark/pull/32918
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error message, please read the guideline first:
https://spark.apache.org/error-message-guidelines.html
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Currently, the file CastSuite.scala becomes big: 2000 lines, 2 base classes, 4 test suites.
In my previous work of Timestamp without time zone, I planned to put new test cases in CastSuiteBase, but they were accidentally added in AnsiCastSuiteBase.
This PR is to break the file down into 3 files. It also moves the test cases about timestamp without time zone to the right base class.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Make development and review easier.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32918: [SPARK-35766][SQL][TESTS] Break down CastSuite/AnsiCastSuite into multiple files
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32918:
URL: https://github.com/apache/spark/pull/32918#issuecomment-861670293
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44343/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32918: [SPARK-35766][SQL][TESTS] Break down CastSuite/AnsiCastSuite into multiple files
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32918:
URL: https://github.com/apache/spark/pull/32918#issuecomment-861640228
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44343/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #32918: [SPARK-35766][SQL][TESTS] Break down CastSuite/AnsiCastSuite into multiple files
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #32918:
URL: https://github.com/apache/spark/pull/32918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32918: [SPARK-35766][SQL][TESTS] Break down CastSuite/AnsiCastSuite into multiple files
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32918:
URL: https://github.com/apache/spark/pull/32918#issuecomment-861792534
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139815/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32918: [SPARK-35766][SQL][TESTS] Break down CastSuite/AnsiCastSuite into multiple files
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32918:
URL: https://github.com/apache/spark/pull/32918#issuecomment-861577296
**[Test build #139815 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139815/testReport)** for PR 32918 at commit [`6428b16`](https://github.com/apache/spark/commit/6428b1675481401b5f0421cc6431d9c9fea3072f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32918: [SPARK-35766][SQL][TESTS] Break down CastSuite/AnsiCastSuite into multiple files
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32918:
URL: https://github.com/apache/spark/pull/32918#discussion_r651896891
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/AnsiCastSuiteBase.scala
##########
@@ -0,0 +1,481 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst.expressions
+
+import java.time.DateTimeException
+
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.util.DateTimeTestUtils
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.sql.types._
+import org.apache.spark.unsafe.types.UTF8String
+
+abstract class AnsiCastSuiteBase extends CastSuiteBase {
+
+ private def testIntMaxAndMin(dt: DataType): Unit = {
+ assert(Seq(IntegerType, ShortType, ByteType).contains(dt))
+ Seq(Int.MaxValue + 1L, Int.MinValue - 1L).foreach { value =>
+ checkExceptionInExpression[ArithmeticException](cast(value, dt), "overflow")
+ checkExceptionInExpression[ArithmeticException](cast(Decimal(value.toString), dt), "overflow")
+ checkExceptionInExpression[ArithmeticException](
+ cast(Literal(value * 1.5f, FloatType), dt), "overflow")
+ checkExceptionInExpression[ArithmeticException](
+ cast(Literal(value * 1.0, DoubleType), dt), "overflow")
+ }
+ }
+
+ private def testLongMaxAndMin(dt: DataType): Unit = {
+ assert(Seq(LongType, IntegerType).contains(dt))
+ Seq(Decimal(Long.MaxValue) + Decimal(1), Decimal(Long.MinValue) - Decimal(1)).foreach { value =>
+ checkExceptionInExpression[ArithmeticException](
+ cast(value, dt), "overflow")
+ checkExceptionInExpression[ArithmeticException](
+ cast((value * Decimal(1.1)).toFloat, dt), "overflow")
+ checkExceptionInExpression[ArithmeticException](
+ cast((value * Decimal(1.1)).toDouble, dt), "overflow")
+ }
+ }
+
+ test("ANSI mode: Throw exception on casting out-of-range value to byte type") {
Review comment:
we can override the `test` method in `AnsiCastSuiteBase` to automatically add the "ANSI mode:" prefix in the test name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32918: [SPARK-35766][SQL][TESTS] Break down CastSuite/AnsiCastSuite into multiple files
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32918:
URL: https://github.com/apache/spark/pull/32918#issuecomment-861577296
**[Test build #139815 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139815/testReport)** for PR 32918 at commit [`6428b16`](https://github.com/apache/spark/commit/6428b1675481401b5f0421cc6431d9c9fea3072f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32918: [SPARK-35766][SQL][TESTS] Break down CastSuite/AnsiCastSuite into multiple files
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32918:
URL: https://github.com/apache/spark/pull/32918#issuecomment-861615400
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44343/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32918: [SPARK-35766][SQL][TESTS] Break down CastSuite/AnsiCastSuite into multiple files
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32918:
URL: https://github.com/apache/spark/pull/32918#discussion_r651907915
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/AnsiCastSuiteBase.scala
##########
@@ -0,0 +1,481 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst.expressions
+
+import java.time.DateTimeException
+
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.util.DateTimeTestUtils
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.sql.types._
+import org.apache.spark.unsafe.types.UTF8String
+
+abstract class AnsiCastSuiteBase extends CastSuiteBase {
+
+ private def testIntMaxAndMin(dt: DataType): Unit = {
+ assert(Seq(IntegerType, ShortType, ByteType).contains(dt))
+ Seq(Int.MaxValue + 1L, Int.MinValue - 1L).foreach { value =>
+ checkExceptionInExpression[ArithmeticException](cast(value, dt), "overflow")
+ checkExceptionInExpression[ArithmeticException](cast(Decimal(value.toString), dt), "overflow")
+ checkExceptionInExpression[ArithmeticException](
+ cast(Literal(value * 1.5f, FloatType), dt), "overflow")
+ checkExceptionInExpression[ArithmeticException](
+ cast(Literal(value * 1.0, DoubleType), dt), "overflow")
+ }
+ }
+
+ private def testLongMaxAndMin(dt: DataType): Unit = {
+ assert(Seq(LongType, IntegerType).contains(dt))
+ Seq(Decimal(Long.MaxValue) + Decimal(1), Decimal(Long.MinValue) - Decimal(1)).foreach { value =>
+ checkExceptionInExpression[ArithmeticException](
+ cast(value, dt), "overflow")
+ checkExceptionInExpression[ArithmeticException](
+ cast((value * Decimal(1.1)).toFloat, dt), "overflow")
+ checkExceptionInExpression[ArithmeticException](
+ cast((value * Decimal(1.1)).toDouble, dt), "overflow")
+ }
+ }
+
+ test("ANSI mode: Throw exception on casting out-of-range value to byte type") {
Review comment:
oh I see
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #32918: [SPARK-35766][SQL][TESTS] Break down CastSuite/AnsiCastSuite into multiple files
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #32918:
URL: https://github.com/apache/spark/pull/32918#issuecomment-861670842
@gengliangwang I have huge conflicts in my PR https://github.com/apache/spark/pull/32909 after rebasing on this. Just to double check, did you just move the code around w/o any modifications?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #32918: [SPARK-35766][SQL][TESTS] Break down CastSuite/AnsiCastSuite into multiple files
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #32918:
URL: https://github.com/apache/spark/pull/32918#issuecomment-861636519
Merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #32918: [SPARK-35766][SQL][TESTS] Break down CastSuite/AnsiCastSuite into multiple files
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #32918:
URL: https://github.com/apache/spark/pull/32918#discussion_r651904009
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/AnsiCastSuiteBase.scala
##########
@@ -0,0 +1,481 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst.expressions
+
+import java.time.DateTimeException
+
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.util.DateTimeTestUtils
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.sql.types._
+import org.apache.spark.unsafe.types.UTF8String
+
+abstract class AnsiCastSuiteBase extends CastSuiteBase {
+
+ private def testIntMaxAndMin(dt: DataType): Unit = {
+ assert(Seq(IntegerType, ShortType, ByteType).contains(dt))
+ Seq(Int.MaxValue + 1L, Int.MinValue - 1L).foreach { value =>
+ checkExceptionInExpression[ArithmeticException](cast(value, dt), "overflow")
+ checkExceptionInExpression[ArithmeticException](cast(Decimal(value.toString), dt), "overflow")
+ checkExceptionInExpression[ArithmeticException](
+ cast(Literal(value * 1.5f, FloatType), dt), "overflow")
+ checkExceptionInExpression[ArithmeticException](
+ cast(Literal(value * 1.0, DoubleType), dt), "overflow")
+ }
+ }
+
+ private def testLongMaxAndMin(dt: DataType): Unit = {
+ assert(Seq(LongType, IntegerType).contains(dt))
+ Seq(Decimal(Long.MaxValue) + Decimal(1), Decimal(Long.MinValue) - Decimal(1)).foreach { value =>
+ checkExceptionInExpression[ArithmeticException](
+ cast(value, dt), "overflow")
+ checkExceptionInExpression[ArithmeticException](
+ cast((value * Decimal(1.1)).toFloat, dt), "overflow")
+ checkExceptionInExpression[ArithmeticException](
+ cast((value * Decimal(1.1)).toDouble, dt), "overflow")
+ }
+ }
+
+ test("ANSI mode: Throw exception on casting out-of-range value to byte type") {
Review comment:
Hmm, that will affect the common test cases in CastSuiteBase which are not ANSI-mode-specific behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32918: [SPARK-35766][SQL][TESTS] Break down CastSuite/AnsiCastSuite into multiple files
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32918:
URL: https://github.com/apache/spark/pull/32918#issuecomment-861792534
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139815/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32918: [SPARK-35766][SQL][TESTS] Break down CastSuite/AnsiCastSuite into multiple files
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32918:
URL: https://github.com/apache/spark/pull/32918#issuecomment-861670293
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44343/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32918: [SPARK-35766][SQL][TESTS] Break down CastSuite/AnsiCastSuite into multiple files
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32918:
URL: https://github.com/apache/spark/pull/32918#issuecomment-861774509
**[Test build #139815 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139815/testReport)** for PR 32918 at commit [`6428b16`](https://github.com/apache/spark/commit/6428b1675481401b5f0421cc6431d9c9fea3072f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `abstract class AnsiCastSuiteBase extends CastSuiteBase `
* `class CastSuiteWithAnsiModeOn extends AnsiCastSuiteBase `
* `class AnsiCastSuiteWithAnsiModeOn extends AnsiCastSuiteBase `
* `class AnsiCastSuiteWithAnsiModeOff extends AnsiCastSuiteBase `
* `abstract class CastSuiteBase extends SparkFunSuite with ExpressionEvalHelper `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #32918: [SPARK-35766][SQL][TESTS] Break down CastSuite/AnsiCastSuite into multiple files
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #32918:
URL: https://github.com/apache/spark/pull/32918#issuecomment-861674490
@MaxGekk Sorry about that. Yes I just moved code around. I checked #32909 and I think you can consider removing/stashing the changes in `CastSuite.scala` and apply them after rebasing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org