[GitHub] [accumulo] hkeebler commented on issue #1122: Make thrift transport pool more concurrent

[GitBox <gi...@apache.org>]

hkeebler commented on issue #1122: Make thrift transport pool more concurrent
URL: https://github.com/apache/accumulo/issues/1122#issuecomment-496650299
 
 
   Is this a straight forward as setting the below and removing the synchronized blocks? 
    ```
      Queue<CachedConnection> unreserved = new ConcurrentLinkedQueue<>();
       Map<CachedTTransport,CachedConnection> reserved = new ConcurrentHashMap<>();
   .................. 
     private Map<ThriftTransportKey,CachedConnections> cache = new ConcurrentHashMap<>();
   ```
   I do not see any unit tests for this.  There is a TransportCachingIT but I'll need to review to see if it adequately test this.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services