You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "waitinfuture (via GitHub)" <gi...@apache.org> on 2023/01/28 04:12:54 UTC
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1174: [CELEBORN-229][FOLLOWUP] Support collect metrics with customized labels
waitinfuture commented on code in PR #1174:
URL: https://github.com/apache/incubator-celeborn/pull/1174#discussion_r1089630457
##########
common/src/main/scala/org/apache/celeborn/common/metrics/MetricLabels.scala:
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.celeborn.common.metrics
+
+private[metrics] trait MetricLabels {
+ val labels: Map[String, String]
+
+ def labelString: String = MetricLabels.labelString(labels)
+}
+
+object MetricLabels {
+ def labelString(labels: Map[String, String]): String = {
Review Comment:
This method should ensure that if two maps contain the same entries, the return value should be identical. However HashMaps don't guarantee order. I think we can simply sort the strings before concat together(under the assumption that the labels will not be too many)
```
labels.map { case (key: String, value: String) => s"""$key="$value"""" }.toList.sorted.mkString
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org