You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by lc...@apache.org on 2017/01/03 22:36:38 UTC

[3/7] beam git commit: [BEAM-1223] Resolved some type-safety related warnings.

[BEAM-1223] Resolved some type-safety related warnings.


Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/6b68699c
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/6b68699c
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/6b68699c

Branch: refs/heads/master
Commit: 6b68699cd75e8b17bc84cf58053fe1f7583e447f
Parents: 78a360e
Author: Stas Levin <st...@gmail.com>
Authored: Mon Jan 2 18:29:21 2017 +0200
Committer: Luke Cwik <lc...@google.com>
Committed: Tue Jan 3 14:28:19 2017 -0800

----------------------------------------------------------------------
 .../core/src/main/java/org/apache/beam/sdk/transforms/Max.java   | 4 ++--
 .../core/src/main/java/org/apache/beam/sdk/transforms/Min.java   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/beam/blob/6b68699c/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Max.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Max.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Max.java
index 696bed9..91851bc 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Max.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Max.java
@@ -195,7 +195,7 @@ public class Max {
    */
   public static <T, ComparatorT extends Comparator<? super T> & Serializable>
   Combine.Globally<T, T> globally(ComparatorT comparator) {
-    return Combine.<T, T>globally(Max.of(comparator));
+    return Combine.<T, T>globally(Max.<T, ComparatorT>of(comparator));
   }
 
   /**
@@ -207,7 +207,7 @@ public class Max {
    */
   public static <K, T, ComparatorT extends Comparator<? super T> & Serializable>
   Combine.PerKey<K, T, T> perKey(ComparatorT comparator) {
-    return Combine.<K, T, T>perKey(Max.of(comparator));
+    return Combine.<K, T, T>perKey(Max.<T, ComparatorT>of(comparator));
   }
 
   /////////////////////////////////////////////////////////////////////////////

http://git-wip-us.apache.org/repos/asf/beam/blob/6b68699c/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Min.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Min.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Min.java
index b208929..3518a35 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Min.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Min.java
@@ -195,7 +195,7 @@ public class Min {
    */
   public static <T, ComparatorT extends Comparator<? super T> & Serializable>
   Combine.Globally<T, T> globally(ComparatorT comparator) {
-    return Combine.<T, T>globally(Min.of(comparator));
+    return Combine.<T, T>globally(Min.<T, ComparatorT>of(comparator));
   }
 
   /**
@@ -207,7 +207,7 @@ public class Min {
    */
   public static <K, T, ComparatorT extends Comparator<? super T> & Serializable>
   Combine.PerKey<K, T, T> perKey(ComparatorT comparator) {
-    return Combine.<K, T, T>perKey(Min.of(comparator));
+    return Combine.<K, T, T>perKey(Min.<T, ComparatorT>of(comparator));
   }
 
   /////////////////////////////////////////////////////////////////////////////