You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/02/14 20:22:57 UTC

[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #48: Replace Akka with Pekko for classes and functions

pjfanning commented on code in PR #48:
URL: https://github.com/apache/incubator-pekko-http/pull/48#discussion_r1106332152


##########
docs/src/test/java/docs/http/javadsl/server/PekkoHttp1020MigrationExample.java:
##########
@@ -13,7 +13,7 @@
 import org.apache.pekko.stream.Materializer;
 
 @SuppressWarnings("deprecation")
-public class AkkaHttp1020MigrationExample {
+public class PekkoHttp1020MigrationExample {

Review Comment:
   I vote for keeping the new name - it easier to explain all the names now have Pekko in them - as opposed to explaining on a case by case basis. One extra option is to just to remove this test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org