[jira] [Commented] (BEAM-389) DelegateCoder needs equals and hashCode

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355809#comment-15355809 ] 

ASF GitHub Bot commented on BEAM-389:
-------------------------------------

GitHub user peihe opened a pull request:

    https://github.com/apache/incubator-beam/pull/559

    [BEAM-389] Provide equals and hashCode in DelegateCoder

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/peihe/incubator-beam fix-delegate-coder-equals

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/559.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #559
    
----
commit c46f3bb7810d26fcd8964f0141ed121c72f926a1
Author: Pei He <pe...@google.com>
Date:   2016-06-29T21:21:42Z

    Provide equals and hashCode in DelegateCoder

----


> DelegateCoder needs equals and hashCode
> ---------------------------------------
>
>                 Key: BEAM-389
>                 URL: https://issues.apache.org/jira/browse/BEAM-389
>             Project: Beam
>          Issue Type: Bug
>            Reporter: Pei He
>            Assignee: Pei He
>            Priority: Minor
>
> Currently, DelegateCoder inherit equals() and hashCode() from StandardCoder.
> And, it makes DelegateCoder.of(VarIntCoder) equal to DelegateCoder.of(BigEndianIntegerCoder).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)