[2/9] incubator-kudu git commit: Remove autoreconf calls in download-thirdparty.sh

[to...@apache.org]

Remove autoreconf calls in download-thirdparty.sh

The original reason we added these (changing the stdlib on OS X) is no longer a
concern, so it can be removed.

Change-Id: I85c9053729facb0a50b290844a84099e7cff46f5
Reviewed-on: http://gerrit.cloudera.org:8080/1969
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/ee13c00a
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/ee13c00a
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/ee13c00a

Branch: refs/heads/master
Commit: ee13c00a5df5d4ad1cac05b49048a9eae256e2f2
Parents: 7e34050
Author: Dan Burkert <da...@cloudera.com>
Authored: Fri Jan 29 17:40:02 2016 -0800
Committer: Dan Burkert <da...@cloudera.com>
Committed: Sat Jan 30 02:53:05 2016 +0000

----------------------------------------------------------------------
 thirdparty/download-thirdparty.sh | 34 ----------------------------------
 1 file changed, 34 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/ee13c00a/thirdparty/download-thirdparty.sh
----------------------------------------------------------------------
diff --git a/thirdparty/download-thirdparty.sh b/thirdparty/download-thirdparty.sh
index 2cd7889..2bdd519 100755
--- a/thirdparty/download-thirdparty.sh
+++ b/thirdparty/download-thirdparty.sh
@@ -16,29 +16,6 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-#
-# Note regarding the autoreconf calls:
-#
-# Mac OS 10.8 shipped a clang-based C++ toolchain that provides both GNU libstdc++ and LLVM's
-# libc++. The default library used is libstdc++, though one can override that with the
-# -stdlib=libc++ option to clang (while compiling and linking). In 10.9, the default policy has
-# switched: libc++ is now the default, and to use libstdc++ you need to pass -stdlib=libstdc++
-# as a command line option.
-#
-# This is relevant to Kudu because libc++ does not support tr1; to use tr1 features like tr1/memory
-# we must use them from the C++11 namespace (i.e. <memory> instead of <tr1/memory> and -std=c++11
-# to clang).
-#
-# Setting CXXFLAGS=-stdlib=libstdc++ suffices for an autotools-based project, and this is what we do
-# in build-thirdparty.sh. However, older versions of autotools will filter out -stdlib=libstdc++
-# from a shared library link invocation. This leads to link failures with every std symbol listed
-# as "undefined". To fix this, one must regenerate the autotools system for each library on a
-# machine with modern brews of autotools. Running "autoconf -fvi" inside the library's directory
-# is sufficient. See this link for more information:
-#
-# http://trac.macports.org/ticket/32982
-#
-# This is why all the cmake-based projects have their autotools regenerated with "autoreconf -fvi".
 
 set -e
 
@@ -94,7 +71,6 @@ if [ ! -d $GLOG_DIR ]; then
   pushd $GLOG_DIR
   patch -p0 < $TP_DIR/patches/glog-issue-198-fix-unused-warnings.patch
   touch patchlevel-$GLOG_PATCHLEVEL
-  autoreconf -fvi
   popd
   echo
 fi
@@ -105,9 +81,6 @@ fi
 
 if [ ! -d $GFLAGS_DIR ]; then
   fetch_and_expand gflags-${GFLAGS_VERSION}.zip
-  pushd $GFLAGS_DIR
-  autoreconf -fvi
-  popd
 fi
 
 # Check that the gperftools patch has been applied.
@@ -122,16 +95,12 @@ if [ ! -d $GPERFTOOLS_DIR ]; then
   patch -p1 < $TP_DIR/patches/gperftools-Change-default-TCMALLOC_TRANSFER_NUM_OBJ-to-40.patch
   patch -p1 < $TP_DIR/patches/gperftools-hook-mi_force_unlock-on-OSX-instead-of-pthread_atfork.patch
   touch patchlevel-$GPERFTOOLS_PATCHLEVEL
-  autoreconf -fvi
   popd
   echo
 fi
 
 if [ ! -d $PROTOBUF_DIR ]; then
   fetch_and_expand protobuf-${PROTOBUF_VERSION}.tar.gz
-  pushd $PROTOBUF_DIR
-  autoreconf -fvi
-  popd
 fi
 
 if [ ! -d $CMAKE_DIR ]; then
@@ -140,9 +109,6 @@ fi
 
 if [ ! -d $SNAPPY_DIR ]; then
   fetch_and_expand snappy-${SNAPPY_VERSION}.tar.gz
-  pushd $SNAPPY_DIR
-  autoreconf -fvi
-  popd
 fi
 
 if [ ! -d $ZLIB_DIR ]; then