[jira] [Commented] (CASSANDRA-16200) Nodetool ring unit testing

["David Capwell (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-16200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243449#comment-17243449 ] 

David Capwell commented on CASSANDRA-16200:
-------------------------------------------

just saw this, had a few questions

[~Bereng], [~yifanc]made the change to no longer touch stdout in nodetool, what are the cases you see touching stdout?  This looks more like a bug, so shouldn't try to work around it.

Also saw that we added the following to src/java/org/apache/cassandra/tools/nodetool/Ring.java

{code}
String addressNPort = stat.endpointWithPort.toString().replaceAll("^/", "");
{code}

Can you explain why?  [~jmeredithco] went through and standardized our output and requested the breaking changes on the dev list, this change moves away from that, so wondering what the motivation was.

> Nodetool ring unit testing
> --------------------------
>
>                 Key: CASSANDRA-16200
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16200
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Test/dtest/java
>            Reporter: Berenguer Blasi
>            Assignee: Berenguer Blasi
>            Priority: Normal
>             Fix For: 4.0-beta3
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Add nodetool ring testing



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org